libticalcs: fix erroneous bashism in configure script #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure scripts are POSIX /bin/sh scripts and cannot have bash-specific syntax. The `test xxx == yyy` construct with double equals is a bash-specific alias for single equals. It does exactly the same thing as single equals -- it provides no additional functionality, no behavior changes, it is *exactly* the same but with an additional alternate spelling. In exchange for doing nothing, it breaks muscle memory when writing POSIX sh scripts and tricks developers into writing the wrong thing. It should never be used under any circumstances. Ideally it would be removed altogether from GNU bash. Bug: https://bugs.gentoo.org/723452
|
Right, thanks :) |
|
I believe that Debian unfortunately still configures their dash package without LINENO support, specifically to make GNU autoconf detect it as a "crippled" shell and search for bash to see if it can re-exec using that. Which means it's hard to actually test this on Debian. :( |
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Mar 29, 2024
* QA Notice: Abnormal configure code * * checking for the host compiler... ./configure: 17678: test: xx86_64-pc-linux-gnu: unexpected operator Bug: debrouxl/tilibs#87 Closes: https://bugs.gentoo.org/723452 Signed-off-by: Eli Schwartz <[email protected]> Signed-off-by: Sam James <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure scripts are POSIX /bin/sh scripts and cannot have bash-specific syntax. The
test xxx == yyyconstruct with double equals is a bash-specific alias for single equals. It does exactly the same thing as single equals -- it provides no additional functionality, no behavior changes, it is exactly the same but with an additional alternate spelling. In exchange for doing nothing, it breaks muscle memory when writing POSIX sh scripts and tricks developers into writing the wrong thing.It should never be used under any circumstances. Ideally it would be removed altogether from GNU bash.
Bug: https://bugs.gentoo.org/723452