Fix only replacing wildcard at end in toNamespace
#778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs state that, when running
debug.disable()
, it will return the namespaces currently enabled and skipped. They are, however, often malformed. This seems to be because thetoNamespace
method only replaces a trailing*
.console.log(prevConfig);
should have returnedapi:*,-*:verbose,-api:*:verbose
.The issue seems to be fixed by removing the
$
in the replace regexp intoNamespace
.It might be nice to improve the following test too:
However, for the sake of keeping this PR clean, I haven't added that to this PR.