Skip to content

Fix unittests#859

Merged
decalage2 merged 3 commits intodecalage2:masterfrom
christian-intra2net:unittest-automation
May 31, 2024
Merged

Fix unittests#859
decalage2 merged 3 commits intodecalage2:masterfrom
christian-intra2net:unittest-automation

Conversation

@christian-intra2net
Copy link
Copy Markdown
Contributor

Introduced an error when silencing pylint warnings. This should fix it. No idea why this did not turn up in my unittests.

Introduced an error when silencing pylint warnings. This should fix it.
@christian-intra2net christian-intra2net force-pushed the unittest-automation branch 3 times, most recently from 054ba0f to 6b18caa Compare May 31, 2024 14:11
@christian-intra2net
Copy link
Copy Markdown
Contributor Author

Found some discrepancies in unittest results between what @kijeong found for PR #723 and what I find. I suspect that system encoding plays a role here.
Ignore the one sample for now, which shows this discrepancy (olevba/sample_with_vba.ppt)

Another recent pull request changed the outcome of 2 tests for one
sample. However, those results do not appear on my system or the github
integrated unittest systems. Maybe detection is dependent on system
encoding?

Need to investigate, exclude sample for now.
Should help debugging unexpected results.
Copy link
Copy Markdown
Owner

@decalage2 decalage2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants