fix(backend-git-gateway): re-write GitHub pagination links #3135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If Git Gateway is allowing raw provider URL's in the response headers, I think it would make sense to fix it in Git Gateway itself. |
|
Going to go ahead and merge this to fix for now, we can revert if/when Git Gateway support comes. |
erquhart
approved these changes
Jan 24, 2020
|
Opened this netlify/git-gateway#48, also I forgot we can set |
nathankitchen
pushed a commit
to nathankitchen/netlify-cms-backend-azure
that referenced
this pull request
Feb 24, 2020
vladdu
pushed a commit
to vladdu/netlify-cms
that referenced
this pull request
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3129 which will happen on any git-gateway+GitHub setup with more than 30 pull requests.
See my comment here #3129 (comment).
We currently follow GitHub pagination link headers as is which breaks with
git-gateway.Tested with pull requests as this is the only place we follow paginations links.
Another option is to do it in the
git-gatewayproject itself.@erquhart Thoughts?