-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Move polyfill resolution from webpack to package.json #7395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Update: I noticed that With this change in place, we could also remove the |
|
@fgnass, I agree with the |
|
I take it back. This PR solves #7521, so I would merge as is. |
Summary
This PR simplifies the setup for users consuming
decap-cms-appdirectly by addressing Node.js built-in dependencies in a different way.Problem:
path)decap-cms-appdirectly must manually configure their build tools to provide these polyfillsSolution:
browserfield inpackage.jsonto specify browser-compatible alternatives@iarna/toml/parse-stringinstead of full@iarna/tomlto eliminatestreamdependencyminimatchto a more recent version which removes Node.js built-in dependenciesThese changes make the library more portable and easier to integrate across different build environments.
Test plan
Checklist
Please add a
xinside each checkbox:A picture of a cute animal (not mandatory but encouraged)
🐣