fix(#7410): add proper typings for registerWidget and CmsBackendClass #7411
+1,295
−729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cbdb932.
|
That is a big diff to review 😅 We are working on some other features at the moment, I really hope to get to your PRs soon! |
|
I know 😅 No worries, I'm happily using my fork in the meantime. I squashed the commits of the parent PR to at least reduce the number of commits in this one and make it possible to review both in sequence. Let me know if there is anything else I can do to make your life easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR that supersedes #7402 and fixes #7410.
It also addresses the
// TODO: type properlycomment that was previously in index.d.tsIn general, this shows how we can gradually migrate the codebase to TypeScript.