Skip to content

fix: adhere to remark's tokenizer rules #7315 #7444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: adhere to remark's tokenizer rules #7315 #7444

wants to merge 2 commits into from

Conversation

fgnass
Copy link
Contributor

@fgnass fgnass commented Mar 28, 2025

This PR fixes #7315 by implementing @manulari's suggested approach.

  • The processing time is now linear again
  • A warning is logged when a pattern uses the multiline flag
  • A warning is logged when the match does not start at the beginning of the block

@fgnass fgnass requested a review from a team as a code owner March 28, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Current code in remarkShortcodes.js misunderstands how remark's block tokenizers are supposed to work
2 participants
@fgnass @martinjagodic