ADR-156-scene-triggers-custom-animations #156
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
8529786
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://117abf48.adr-cvq.pages.dev |
| Branch Preview URL: | https://adr-155-trigger-animations.adr-cvq.pages.dev |
menduz
reviewed
Dec 15, 2022
menduz
reviewed
Dec 15, 2022
| Since the animations are downloaded together with the scene's content, there's a corner case that needs to be handled gracefully: Player A sees Player B far away, but has not downloaded the scene where Player B is standing. The scene triggers an animation on Player B, but Player A doesn't have that animation downloaded. In this scenario, it's acceptable for Player A to not see the animation, since Player A is also not seeing the scene that gives that animation context. | ||
|
|
||
|
|
||
| **Syntax and semantics** |
There was a problem hiding this comment.
how will the scene creator specify and upload the animations? I think we should leverage as much as possible the emotes functionality for it. Any idea on how it may look?
Co-authored-by: menduz <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
menduz
changed the title
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Co-authored-by: Kevin Szuchet <[email protected]> Signed-off-by: Nicolas Earnshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.