Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add web editor documentation #229

Merged
merged 4 commits into from
Aug 17, 2023
Merged

feat: add web editor documentation #229

merged 4 commits into from
Aug 17, 2023

Conversation

meelrossi
Copy link

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 16, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2e73980
Status: ✅  Deploy successful!
Preview URL: https://e2c77603.new-docs-6m4.pages.dev
Branch Preview URL: https://feat-web-editor.new-docs-6m4.pages.dev

View logs

Signed-off-by: Nicolas Earnshaw <[email protected]>
@nearnshaw
Copy link
Member

Very well written @meelrossi!
I did some minor adjustments here and there, but it was already really good :)

@nearnshaw
Copy link
Member

I noticed this PR moves the examples page up a level
Even though that logically makes sense bc there was only one page in that section, it doesn't look that good visually:

Screenshot 2023-08-17 at 10 25 32

I find it confusing, I tend to think it's a subsection of the one above
And the same happens with the new Web editor lose document
I think it would be worth for the web editor to also have its own folder, in the future I think we'll likely have more content there also, surely for smart items we can have one separate page soon

@meelrossi

@meelrossi meelrossi merged commit 2b60ce7 into main Aug 17, 2023
@meelrossi meelrossi deleted the feat/web-editor branch August 17, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants