Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make createReactBasedUiSystem public #1063

Merged
merged 3 commits into from
Feb 19, 2025
Merged

Conversation

cyaiox
Copy link
Collaborator

@cyaiox cyaiox commented Feb 6, 2025

This PR updates the access modifier for the class createReactBasedUiSystem, allowing us to instantiate the system in another library, such as @dcl/asset-packs.

It also passes the playerHelper object as a param to the initializer method: initAssetPack, allowing us to access the player data from the lib @dcl/asset-packs.

Copy link

cloudflare-workers-and-pages bot commented Feb 6, 2025

Deploying js-sdk-toolchain with  Cloudflare Pages  Cloudflare Pages

Latest commit: c8d5e4e
Status: ✅  Deploy successful!
Preview URL: https://ffd2d020.js-sdk-toolchain.pages.dev
Branch Preview URL: https://feat-update-react-ecs.js-sdk-toolchain.pages.dev

View logs

Copy link
Contributor

github-actions bot commented Feb 6, 2025

Test this pull request

  • The @dcl/sdk package can be tested in scenes by running

    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-react-ecs/dcl-sdk-7.7.6-13418144862.commit-95f0b88.tgz"
  • To test with npx init

    export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-react-ecs/dcl-sdk-commands-7.7.6-13418144862.commit-95f0b88.tgz"
    npx $SDK_COMMANDS init
  • The @dcl/inspector package can be tested by visiting this url

    • Or by installing it via NPM
    npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/feat/update-react-ecs/@dcl/inspector/dcl-inspector-7.7.6-13418144862.commit-95f0b88.tgz"
  • The /changerealm command to test test in-world

    /changerealm https://sdk-team-cdn.decentraland.org/ipfs/feat/update-react-ecs-e2e
    
  • You can preview this build entering:
    https://playground.decentraland.org/?sdk-branch=feat/update-react-ecs

@cyaiox cyaiox marked this pull request as ready for review February 17, 2025 12:46
Copy link
Contributor

@gonpombo8 gonpombo8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the only weird thing that i see here is that if the user has a UI defined in the code, then it would be overriden by the admin toolkit.

@cyaiox cyaiox force-pushed the feat/update-react-ecs branch from e96b36f to c8d5e4e Compare February 19, 2025 17:01
@cyaiox cyaiox enabled auto-merge (squash) February 19, 2025 17:01
@cyaiox cyaiox merged commit c459a2f into main Feb 19, 2025
8 checks passed
@cyaiox cyaiox deleted the feat/update-react-ecs branch February 19, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants