feat: allow creators to reset a quest instance (#175) #400
Annotations
11 warnings
unnecessary use of `get("y").is_none()`:
crates/protocol/src/quests/mod.rs#L175
warning: unnecessary use of `get("y").is_none()`
--> crates/protocol/src/quests/mod.rs:175:59
|
175 | ... || action_item.parameters.get("y").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("y")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
|
unnecessary use of `get("x").is_none()`:
crates/protocol/src/quests/mod.rs#L174
warning: unnecessary use of `get("x").is_none()`
--> crates/protocol/src/quests/mod.rs:174:55
|
174 | ... if action_item.parameters.get("x").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("x")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
|
unnecessary use of `get("id").is_none()`:
crates/protocol/src/quests/mod.rs#L166
warning: unnecessary use of `get("id").is_none()`
--> crates/protocol/src/quests/mod.rs:166:59
|
166 | ... || action_item.parameters.get("id").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("id")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
|
unnecessary use of `get("y").is_none()`:
crates/protocol/src/quests/mod.rs#L165
warning: unnecessary use of `get("y").is_none()`
--> crates/protocol/src/quests/mod.rs:165:59
|
165 | ... || action_item.parameters.get("y").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("y")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
|
unnecessary use of `get("x").is_none()`:
crates/protocol/src/quests/mod.rs#L164
warning: unnecessary use of `get("x").is_none()`
--> crates/protocol/src/quests/mod.rs:164:55
|
164 | ... if action_item.parameters.get("x").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("x")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
|
unnecessary use of `get("y").is_none()`:
crates/protocol/src/quests/mod.rs#L156
warning: unnecessary use of `get("y").is_none()`
--> crates/protocol/src/quests/mod.rs:156:59
|
156 | ... || action_item.parameters.get("y").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("y")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
|
unnecessary use of `get("x").is_none()`:
crates/protocol/src/quests/mod.rs#L155
warning: unnecessary use of `get("x").is_none()`
--> crates/protocol/src/quests/mod.rs:155:55
|
155 | ... if action_item.parameters.get("x").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("x")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
= note: `#[warn(clippy::unnecessary_get_then_check)]` on by default
|
this `let...else` may be rewritten with the `?` operator:
crates/protocol/src/quests/mod.rs#L30
warning: this `let...else` may be rewritten with the `?` operator
--> crates/protocol/src/quests/mod.rs:30:9
|
30 | / let Some(definition) = &self.definition else {
31 | | return None;
32 | | };
| |__________^ help: replace it with: `let definition = &self.definition?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
|
unused import: `prost::Message`:
/home/runner/work/quests/quests/target/debug/build/quests_protocol-48fb078a2c83fb49/out/decentraland.quests.rs#L503
warning: unused import: `prost::Message`
--> /home/runner/work/quests/quests/target/debug/build/quests_protocol-48fb078a2c83fb49/out/decentraland.quests.rs:503:5
|
503 | use prost::Message;
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
clippy_check
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: arduino/setup-protoc@v1, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
clippy_check
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|