fix: getting more than one connection for Redis channel subscriber #408
clippy
9 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 9 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.78.0 (9b00956e5 2024-04-29)
- cargo 1.78.0 (54d8815d0 2024-03-26)
- clippy 0.1.78 (9b00956 2024-04-29)
Annotations
Check warning on line 175 in crates/protocol/src/quests/mod.rs
github-actions / clippy
unnecessary use of `get("y").is_none()`
warning: unnecessary use of `get("y").is_none()`
--> crates/protocol/src/quests/mod.rs:175:59
|
175 | ... || action_item.parameters.get("y").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("y")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
Check warning on line 174 in crates/protocol/src/quests/mod.rs
github-actions / clippy
unnecessary use of `get("x").is_none()`
warning: unnecessary use of `get("x").is_none()`
--> crates/protocol/src/quests/mod.rs:174:55
|
174 | ... if action_item.parameters.get("x").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("x")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
Check warning on line 166 in crates/protocol/src/quests/mod.rs
github-actions / clippy
unnecessary use of `get("id").is_none()`
warning: unnecessary use of `get("id").is_none()`
--> crates/protocol/src/quests/mod.rs:166:59
|
166 | ... || action_item.parameters.get("id").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("id")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
Check warning on line 165 in crates/protocol/src/quests/mod.rs
github-actions / clippy
unnecessary use of `get("y").is_none()`
warning: unnecessary use of `get("y").is_none()`
--> crates/protocol/src/quests/mod.rs:165:59
|
165 | ... || action_item.parameters.get("y").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("y")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
Check warning on line 164 in crates/protocol/src/quests/mod.rs
github-actions / clippy
unnecessary use of `get("x").is_none()`
warning: unnecessary use of `get("x").is_none()`
--> crates/protocol/src/quests/mod.rs:164:55
|
164 | ... if action_item.parameters.get("x").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("x")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
Check warning on line 156 in crates/protocol/src/quests/mod.rs
github-actions / clippy
unnecessary use of `get("y").is_none()`
warning: unnecessary use of `get("y").is_none()`
--> crates/protocol/src/quests/mod.rs:156:59
|
156 | ... || action_item.parameters.get("y").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("y")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
Check warning on line 155 in crates/protocol/src/quests/mod.rs
github-actions / clippy
unnecessary use of `get("x").is_none()`
warning: unnecessary use of `get("x").is_none()`
--> crates/protocol/src/quests/mod.rs:155:55
|
155 | ... if action_item.parameters.get("x").is_none()
| -----------------------^^^^^^^^^^^^^^^^^^
| |
| help: replace it with: `!action_item.parameters.contains_key("x")`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check
= note: `#[warn(clippy::unnecessary_get_then_check)]` on by default
Check warning on line 32 in crates/protocol/src/quests/mod.rs
github-actions / clippy
this `let...else` may be rewritten with the `?` operator
warning: this `let...else` may be rewritten with the `?` operator
--> crates/protocol/src/quests/mod.rs:30:9
|
30 | / let Some(definition) = &self.definition else {
31 | | return None;
32 | | };
| |__________^ help: replace it with: `let definition = &self.definition?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark
= note: `#[warn(clippy::question_mark)]` on by default
github-actions / clippy
unused import: `prost::Message`
warning: unused import: `prost::Message`
--> /home/runner/work/quests/quests/target/debug/build/quests_protocol-48fb078a2c83fb49/out/decentraland.quests.rs:503:5
|
503 | use prost::Message;
| ^^^^^^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default