Queue display 'syncing' state#54
Closed
Maironire wants to merge 3 commits intodecentraland:mainfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposed change for queue display adds new state, which is shown when player requested queue enter, but he is not yet in sync. It aimed to replace current
StartGameButtonChecksolution mainly for one reason - better user experience. Synchronizing often take dozens of seconds, or even a few minutes; leaving player alone with a disabled button could be frustrating and confusing, whereas explicitly showing him what is going on should be more comfortable experience.Implementation details: it's quite simple, I move
addPlayerlogic to theinternalPlayerSystemand set newly introducedaddPlayerRequestedflag instead. This flag is then used to actually add a player to the queue in the system when sync is achieved (the condition is exactly same as in current solution), and also it's used in queue display to show "Queue is syncing" message. If a player leaves scene before he was added, the flag is reset. As a side effect, it adds a small delay between button press and entering queue (1.25 sec at worst), but I guess it could be treated negligible.2024-10-25.23-17-21.mp4