Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: camera reel - photo detail UI #2898

Draft
wants to merge 136 commits into
base: dev
Choose a base branch
from

Conversation

lorenzo-ranciaffi
Copy link
Contributor

@lorenzo-ranciaffi lorenzo-ranciaffi commented Nov 27, 2024

What does this PR change?

Fix #2897

Implements the screenshot detail panel for the reels and their metadata

How to test the changes?

  1. Launch the explorer with the CLI arg camera-reel
  2. Press "K" to open the reel gallery
  3. Click on a photo in order to open the panel

Our Code Review Standards

https://github.com/decentraland/unity-renderer/blob/master/docs/code-review-standards.md

lorenzo-ranciaffi and others added 30 commits October 29, 2024 14:13
# Conflicts:
#	Explorer/Assets/DCL/Input/UnityInputSystem/DCLInput.cs
#	Explorer/Assets/DCL/Input/UnityInputSystem/DCLInput.inputactions
# Conflicts:
#	Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef
# Conflicts:
#	Explorer/Assets/DCL/InWorldCamera.meta
…/unity-explorer into feat/camera-reel/gallery-ui
@lorenzo-ranciaffi lorenzo-ranciaffi self-assigned this Nov 27, 2024
@lorenzo-ranciaffi lorenzo-ranciaffi changed the title Feat/camera reel/screenshot view Feat: camera reel - photo detail UI Nov 27, 2024
# Conflicts:
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/CameraReel.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/CameraReelGallery.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/ContextMenu.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/MonthGrid.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/StorageProgressBar.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Assets/ThumbnailElement.prefab
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelController.cs
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelGallery.asmdef
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/CameraReelGalleryController.cs
#	Explorer/Assets/DCL/InWorldCamera/CameraReelGallery/Components/PagedCameraReelManager.cs
#	Explorer/Assets/DCL/InWorldCamera/CameraReelStorageService/CameraReelRemoteStorageService.cs
#	Explorer/Assets/DCL/InWorldCamera/CameraReelStorageService/ICameraReelImagesMetadataDatabase.cs
#	Explorer/Assets/DCL/InWorldCamera/CameraReelStorageService/ICameraReelStorageService.cs
#	Explorer/Assets/DCL/InWorldCamera/Textures/Gradient.png.meta
#	Explorer/Assets/DCL/PluginSystem/DCL.Plugins.asmdef
#	Explorer/Assets/DCL/PluginSystem/Global/ExplorePanelPlugin.cs
#	Explorer/Assets/DCL/PluginSystem/Global/Global Plugins Settings.asset
#	Explorer/Assets/DCL/PluginSystem/Global/InWorldCameraPlugin.cs
#	Explorer/Assets/Scripts/Global/Dynamic/DynamicWorldContainer.cs
#	Explorer/Assets/Textures/Common/Checkbox.png.meta
#	Explorer/Assets/Textures/Common/Container6Outline2.png.meta
Copy link
Contributor

badge

New build in progress, come back later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: camera reel - photo detail view
2 participants