fix(ref-imp): make bitcoin logic make less calls to db #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacJChen
requested review from
csuwildcat,
OR13,
tplooker and
troyronda
as code owners
| @@ -309,13 +309,13 @@ describe('BitcoinProcessor', () => { | |||
| describe('transactions', () => { | |||
| it('should get transactions since genesis capped by page size in blocks', async (done) => { | |||
| const verifyMock = spyOn(bitcoinProcessor, 'verifyBlock' as any).and.returnValue(Promise.resolve(true)); | |||
| // return as many as page size | |||
| const transactions: TransactionModel[] = createTransactions(BitcoinProcessor['pageSizeInBlocks'], bitcoinProcessor['genesisBlockNumber'], true); | |||
| bitcoinProcessor['lastProcessedBlock'] = { | |||
There was a problem hiding this comment.
Sanity: the test is getting transaction since genesis, so shouldn't lastProcessedBlock be undefined?
There was a problem hiding this comment.
This is simulating the caller trying to get transactions since genesis (genesis to genesis + 99), and bitcoin's last Processed block is genesis + 100
thehenrytsai
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.