Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm Chart Network Service and annotations #47

Merged
merged 10 commits into from
Oct 9, 2024

Conversation

PatStLouis
Copy link
Contributor

No description provided.

Copy link
Contributor

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tweaks/suggestions.
Also any specific reason to remove the chart linting action?

@PatStLouis
Copy link
Contributor Author

@esune it was giving me headaches on the external dependencies.

This was the error:
Error: no repository definition for https://charts.bitnami.com/bitnami/, [https://charts.bitnami.com/bitnami/.](https://charts.bitnami.com/bitnami/) Please add the missing repos via 'helm repo add'

Copy link
Contributor

@esune esune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@PatStLouis PatStLouis merged commit d93a62e into main Oct 9, 2024
@PatStLouis PatStLouis deleted the add-charts-annotations branch October 9, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants