Skip to content
This repository was archived by the owner on Nov 27, 2024. It is now read-only.

Support for Laravel version 11 and a "latest" version #14

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

luchtech
Copy link

  • On .env, changed the default Laravel version from 8 to 11.
  • Added Laravel 11 and PHP 8.3 steps on docker-image.yml.
  • Added Dockerfiles for PHP 8.3 on nginx and apache.
  • Added 8.3 on php_version options on settings.yml.
  • Added 11 on Laravel options on settings.yml.

- On .env, changed the default Laravel version from 8 to 11.
- Added Laravel 11 and PHP 8.3 steps on docker-image.yml.
- Added Dockerfiles for PHP 8.3 on nginx and apache.
- Added 8.3 on php_version options on settings.yml.
- Added 11 on Laravel options on settings.yml.
@luchtech
Copy link
Author

Hi, @sfx101 @nabad600 . Can you check this out?

@sfx101
Copy link
Member

sfx101 commented May 28, 2024

@nabad600 please check the build error, nginx 8.3 is missing. Thanks

@luchtech
Copy link
Author

@nabad600 Any idea on how I can create this image: ghcr.io/deck-app/nginx:v8.3?

- On .env, changed PHP_VERSION from 8.3 to 8.2 since there's no Docker image yet for that.
- Removed any steps related to PHP 8.3 from docker-image.yml.
- Removed PHP 8.3 from options at settings.yml.
@luchtech
Copy link
Author

luchtech commented Jun 2, 2024

@sfx101 @nabad600 Since there's no image yet for PHP 8.3, I removed it from the options. Can you check it again? I'm sure it won't trip any error this time.

image image

@luchtech luchtech changed the title Support for Laravel 11 and PHP 8.3 Support for Laravel 11 Jun 2, 2024
@nabad600
Copy link
Contributor

nabad600 commented Jun 2, 2024

Hi @luchtech, We are still working... update shortly

@luchtech
Copy link
Author

luchtech commented Jun 2, 2024

Hi @luchtech, We are still working... update shortly

No worries. Take your time. Btw, I'll be making a video tutorial video so I can help spread the word in this Laravel community: https://www.facebook.com/groups/laravelph

Wishing your app to gain more users. ✨

luchtech added 3 commits June 3, 2024 02:59
- Removed the extra ticks from the package.sh code.
- Added the "latest" version on settings.yml.
- Added logic on docker-entrypoint.sh to accommodate for the "latest" Laravel version.
- Added more comments on docker-entrypoint.sh files.
- Fixed bugs on Dockerfile-8.3 files since they were still using php82 extensions.
@luchtech luchtech changed the title Support for Laravel 11 Support for Laravel version 11 and a "latest" version Jun 9, 2024
@luchtech
Copy link
Author

luchtech commented Jun 9, 2024

@nabad600 @sfx101 Hi! I just added an additional logic that will cover future Laravel versions via the "latest" option. I also fixed some typo on Dockerfile-8.3 which were still using PHP 8.2 extensions. Hope you can check it out and hopefully be merged soon! I have also found some bugs when I tried the PHP 8.3 image. Will create a new issue about it.

image

@sfx101
Copy link
Member

sfx101 commented Jun 10, 2024

@luchtech could you please remove Laravel 7 from the list? Thanks

@luchtech
Copy link
Author

luchtech commented Jun 10, 2024

@sfx101 Should I also remove it from tests? Or just from the UI options? For now, I just removed Laravel 7 from settings.yml.

@luchtech
Copy link
Author

@sfx101 Hi again. What's should I do next?

@nabad600
Copy link
Contributor

Hi @luchtech we are update the laravel version(11) with PHP version (8.3), thank you for using DECK.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants