Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[internal] Improve tar packing #54

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[internal] Improve tar packing #54

wants to merge 3 commits into from

Conversation

astef
Copy link
Member

@astef astef commented Dec 11, 2024

Description

This is an improvement of tar, proposed here, then back-ported to v.4.7.0, and proposed in a form of a patch, replacing and older one.

Why do we need it, and what problem does it solve?

Older patch had a several problems:

  • not properly handling errors of file Close (sometimes ignoring them, sometimes silently returning success in the middle of the work)
  • not handling symlinks properly
  • Zip Slip vulnerability
  • bug, when --working-mount-dir is a relative path

What is the expected result?

No change in behavior, only bugs fixed.

Checklist

  • The code is covered by unit tests.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Alexandr Stefurishin <[email protected]>
@astef astef added the enhancement New feature or request label Dec 11, 2024
@astef astef requested a review from AleksZimin December 11, 2024 20:09
@astef astef self-assigned this Dec 11, 2024
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant