Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[internal] fix masked tlshd #87

Merged
merged 5 commits into from
Apr 8, 2025
Merged

[internal] fix masked tlshd #87

merged 5 commits into from
Apr 8, 2025

Conversation

krpsh123
Copy link
Contributor

@krpsh123 krpsh123 commented Apr 4, 2025 •
edited
Loading

Description

  • tlshd masking has been fixed
  • Fixed RPC-with-TLS
  • [crd] clarifying the description

What is the expected result?

  • tlshd masking step in bashible completes successfully
  • When RPC-with-TLS mode is enabled, the pods start correctly.
  • The user sees the correct description of the parameters

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

@krpsh123
fix masked tlshd
cfeafe7 
Signed-off-by: Pavel Karpov <[email protected]>
@krpsh123 krpsh123 added the bug Something isn't working label Apr 4, 2025
@krpsh123 krpsh123 self-assigned this Apr 4, 2025
@krpsh123 krpsh123 requested review from duckhawk and AleksZimin April 7, 2025 12:19
@krpsh123 krpsh123 marked this pull request as ready for review April 7, 2025 12:19
@AleksZimin AleksZimin merged commit 7b80e2f into main Apr 8, 2025
13 of 20 checks passed
@AleksZimin AleksZimin deleted the pkarp-fix-masked-tlshd branch April 8, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duckhawk duckhawk duckhawk approved these changes

@AleksZimin AleksZimin AleksZimin approved these changes

Assignees

@krpsh123 krpsh123

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krpsh123 @duckhawk @AleksZimin