[node-manager] mcm-use-node-manager-bootstrap-token #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Artem Kulyabin <[email protected]>
d2285
force-pushed
the
bootstrap-token-node-manager
branch
2 times, most recently
from
3e9d9eb to
b1e1d88
Compare
name212
reviewed
Mar 24, 2025
| } | ||
|
|
||
| secret = &secretListNodeManager.Items[0] |
There was a problem hiding this comment.
i think we need to sort by metadata.creationTimestamp by desc and get first (get last created token)
There was a problem hiding this comment.
- Need to fallback to old logic if secrets not found
There was a problem hiding this comment.
added sort and old logic(create token by mcm if node manager tokens not found)
name212
reviewed
Mar 24, 2025
| secret, err = c.targetCoreClient.CoreV1().Secrets(metav1.NamespaceSystem).Get(secretName, metav1.GetOptions{}) | ||
| labelSelector := "module=node-manager" | ||
| secretListNodeManager, err := c.targetCoreClient.CoreV1().Secrets(metav1.NamespaceSystem).List(metav1.ListOptions{ | ||
| LabelSelector: labelSelector, |
There was a problem hiding this comment.
i think only label selector is not enough, because in the future we can add another secrets from node manager.
Need to filter by name prefix after getting by label
There was a problem hiding this comment.
- in the token we have label
node-manager.deckhouse.io/node-group=$GROUP_NAMEprobably we need to get by this label depend on fileds from machine deployment or machine resource. Please think about it
There was a problem hiding this comment.
add filter by label from node group name from machine labels
node-manager.deckhouse.io/node-group=$NG_NAME
7ecebfc to
b637bc7
Compare
d2285
force-pushed
the
bootstrap-token-node-manager
branch
3 times, most recently
from
85ad3b6 to
822ab1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
this mr allow to use node-manager boostrap token instead mcm token.
Which issue(s) this PR fixes:
resolve this issue
Special notes for your reviewer:
Release note: