Skip to content

used lazy_emplace_with_hash instead of find/emplace #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vporoshok merged 1 commit into from
Nov 28, 2025
Merged

used lazy_emplace_with_hash instead of find/emplace #206

vporoshok merged 1 commit into from
Nov 28, 2025

Conversation

@cherep58
Copy link
Collaborator

@cherep58 cherep58 commented Nov 17, 2025 •
edited
Loading

I used benchmarks with disabled index generation in QueryableEncodingBimap.

Without lazy_emplace:

BenchmarkFindOrEmplaceWithEmplace   924705982 ns
BenchmarkFindOrEmplaceWithFind      264122486 ns

With lazy_emplace:

BenchmarkFindOrEmplaceWithEmplace   914267778 ns
BenchmarkFindOrEmplaceWithFind      261677424 ns

@cherep58 cherep58 requested a review from gshigin November 17, 2025 15:16
@cherep58 cherep58 self-assigned this Nov 17, 2025
@cherep58 cherep58 requested a review from vporoshok as a code owner November 17, 2025 15:16
@vporoshok vporoshok merged commit 250e7cb into pp Nov 28, 2025
27 checks passed
@vporoshok vporoshok deleted the lazy_emplace branch November 28, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vporoshok vporoshok vporoshok approved these changes

@gshigin gshigin gshigin approved these changes

Assignees

@cherep58 cherep58

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cherep58 @vporoshok @gshigin