Skip to content

Conversation

eofff
Copy link
Contributor

@eofff eofff commented Jun 23, 2025

Description

Add new condition InUse
Add new handler to set InUse condition

Why do we need it, and what problem does it solve?

Other resources may use VI/CVI for creation, we must not delete VI/CVI while they are in use.

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: images
type: feature
summary: Do not allow the deletion of VI/CVI that are in use.

@eofff eofff force-pushed the feat/images/show-usages-while-terminating branch 2 times, most recently from 3a9407e to 9cbcda6 Compare June 24, 2025 15:40
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 24, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jun 24, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 24, 2025
@eofff eofff added this to the v0.21.0 milestone Jun 25, 2025
@nevermarine nevermarine modified the milestones: v0.21.0, v0.22.0 Jun 26, 2025
@eofff eofff force-pushed the feat/images/show-usages-while-terminating branch from ca68426 to 655634a Compare June 26, 2025 20:49
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jun 26, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: cancelled.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@deckhouse-BOaTswain
Copy link
Contributor

Workflow has started.
Follow the progress here: Workflow Run

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jun 26, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 26, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 27, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jun 27, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 27, 2025
@eofff eofff force-pushed the feat/images/show-usages-while-terminating branch from 655634a to ca04dec Compare June 27, 2025 06:42
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Jun 27, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Jun 27, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: success.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Jun 27, 2025
@eofff eofff marked this pull request as ready for review June 27, 2025 08:35
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 25, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 25, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 26, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 26, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 26, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Aug 26, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Aug 26, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Aug 26, 2025
@eofff eofff force-pushed the feat/images/show-usages-while-terminating branch from 88e8ac5 to 29505a7 Compare August 28, 2025 07:20
@nevermarine nevermarine modified the milestones: v0.25.0, v0.26.0 Aug 29, 2025
Valeriy Khorunzhin added 10 commits September 4, 2025 10:35
Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix merge conflicts

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

remove adding finalizers in deleteion handlers

Signed-off-by: Valeriy Khorunzhin <[email protected]>

suite_test

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring tests

Signed-off-by: Valeriy Khorunzhin <[email protected]>

use test context

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

resolve

Signed-off-by: Valeriy Khorunzhin <[email protected]>

remove useless

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix vi lifecycle

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix tests

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fmt

Signed-off-by: Valeriy Khorunzhin <[email protected]>

clear legacy watchers

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix empty ns

Signed-off-by: Valeriy Khorunzhin <[email protected]>

vi watchers reshuffle

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactorig cvi watchers

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix

Signed-off-by: Valeriy Khorunzhin <[email protected]>

oops

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix phase check

Signed-off-by: Valeriy Khorunzhin <[email protected]>

vmbda

Signed-off-by: Valeriy Khorunzhin <[email protected]>

ignore stopped

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix watchers

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix panic

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix vmbda termination

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

up go version dockerfile

Signed-off-by: Valeriy Khorunzhin <[email protected]>

remove unused

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix deletion check

Signed-off-by: Valeriy Khorunzhin <[email protected]>

why we trigger

Signed-off-by: Valeriy Khorunzhin <[email protected]>

inuse handlers refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

remove attache handlers

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix generation check

Signed-off-by: Valeriy Khorunzhin <[email protected]>

logic fix

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix linter

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix linter

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix logic

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix typo

Signed-off-by: Valeriy Khorunzhin <[email protected]>

reuse SetPhaseCondition

Signed-off-by: Valeriy Khorunzhin <[email protected]>

remove unused check

Signed-off-by: Valeriy Khorunzhin <[email protected]>

remove unused

Signed-off-by: Valeriy Khorunzhin <[email protected]>

add comment to condition file

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

concrete

Signed-off-by: Valeriy Khorunzhin <[email protected]>

vi with new design

Signed-off-by: Valeriy Khorunzhin <[email protected]>

cvi new design

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix test data

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix copyright

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

do not requeue

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

fix namespaces order in status

Signed-off-by: Valeriy Khorunzhin <[email protected]>

optimization

Signed-off-by: Valeriy Khorunzhin <[email protected]>

refactoring

Signed-off-by: Valeriy Khorunzhin <[email protected]>

reuse existed diskService

Signed-off-by: Valeriy Khorunzhin <[email protected]>

change builder digest

Signed-off-by: Valeriy Khorunzhin <[email protected]>

empty

empty

fix after rebase

Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@eofff eofff force-pushed the feat/images/show-usages-while-terminating branch from 29505a7 to 650f344 Compare September 4, 2025 07:35
@Isteb4k Isteb4k closed this Sep 4, 2025
@Isteb4k Isteb4k deleted the feat/images/show-usages-while-terminating branch September 4, 2025 07:48
@Isteb4k Isteb4k restored the feat/images/show-usages-while-terminating branch September 4, 2025 07:52
@eofff eofff reopened this Sep 4, 2025
Signed-off-by: Valeriy Khorunzhin <[email protected]>
@Isteb4k Isteb4k marked this pull request as draft September 4, 2025 08:56
@nevermarine nevermarine modified the milestones: v1.0.0, v1.1.0 Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants