Skip to content

chore(e2e): fix VirtualMachineAdditionalNetworkInterfaces test #1472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2025
Merged

chore(e2e): fix VirtualMachineAdditionalNetworkInterfaces test #1472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions tests/e2e/vm_vpc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,16 @@ import (
kc "github.com/deckhouse/virtualization/tests/e2e/kubectl"
)

func WaitVMNetworkReady(opts kc.WaitOptions) {
func WaitForVMNetworkReady(opts kc.WaitOptions) {
GinkgoHelper()
WaitPhaseByLabel(kc.ResourceVM, PhaseRunning, opts)
WaitConditionIsTrueByLabel(kc.ResourceVM, vmcondition.TypeNetworkReady.String(), opts)
}

func WaitForVMRunningPhase(opts kc.WaitOptions) {
GinkgoHelper()
WaitPhaseByLabel(kc.ResourceVM, PhaseRunning, opts)
}

var _ = Describe("VirtualMachineAdditionalNetworkInterfaces", SIGMigration(), ginkgoutil.CommonE2ETestDecorators(), func() {
testCaseLabel := map[string]string{"testcase": "vm-vpc"}
var ns string
Expand Down Expand Up @@ -84,16 +88,16 @@ var _ = Describe("VirtualMachineAdditionalNetworkInterfaces", SIGMigration(), gi

Context("When virtual machines are applied", func() {
It("checks VMs phases", func() {
By("Virtual machine agents should be ready")
WaitVMAgentReady(kc.WaitOptions{
By("Virtual machine should be running")
WaitForVMRunningPhase(kc.WaitOptions{
Labels: testCaseLabel,
Namespace: ns,
Timeout: MaxWaitTimeout,
})
})
It("checks network availability", func() {
By("Network condition should be true")
WaitVMNetworkReady(kc.WaitOptions{
WaitForVMNetworkReady(kc.WaitOptions{
Labels: testCaseLabel,
Namespace: ns,
Timeout: MaxWaitTimeout,
Expand Down Expand Up @@ -151,7 +155,7 @@ var _ = Describe("VirtualMachineAdditionalNetworkInterfaces", SIGMigration(), gi

It("checks network availability after migrations", func() {
By("Network condition should be true")
WaitVMNetworkReady(kc.WaitOptions{
WaitForVMNetworkReady(kc.WaitOptions{
Labels: testCaseLabel,
Namespace: ns,
Timeout: MaxWaitTimeout,
Expand Down
Loading