feat(observability): add VirtualDisk capacity, info, and in-use metrics

images/virtualization-artifact/pkg/monitoring/metrics/vd/data_metric.go

@@ -19,17 +19,27 @@ package vd
 import (
 	"strings"
 
+	"k8s.io/apimachinery/pkg/api/resource"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
 	"github.com/deckhouse/virtualization-controller/pkg/monitoring/metrics/promutil"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2"
+	"github.com/deckhouse/virtualization/api/core/v1alpha2/vdcondition"
 )
 
 type dataMetric struct {
-	Name        string
-	Namespace   string
-	UID         string
-	Phase       v1alpha2.DiskPhase
-	Labels      map[string]string
-	Annotations map[string]string
+	Name                    string
+	Namespace               string
+	UID                     string
+	Phase                   v1alpha2.DiskPhase
+	Labels                  map[string]string
+	Annotations             map[string]string
+	CapacityBytes           int64
+	StorageClass            string
+	PersistentVolumeClaim   string
+	InUse                   bool
+	AttachedVirtualMachines []string
 }
 
 // DO NOT mutate VirtualDisk!
@@ -38,6 +48,9 @@ func newDataMetric(vd *v1alpha2.VirtualDisk) *dataMetric {
 		return nil
 	}
 
+	capacityBytes := parseCapacityBytes(vd.Status.Capacity)
+	inUse, attachedVMs := getInUseStatus(vd)
+
 	return &dataMetric{
 		Name:      vd.Name,
 		Namespace: vd.Namespace,
@@ -49,5 +62,43 @@ func newDataMetric(vd *v1alpha2.VirtualDisk) *dataMetric {
 		Annotations: promutil.WrapPrometheusLabels(vd.GetAnnotations(), "annotation", func(key, _ string) bool {
 			return strings.HasPrefix(key, "kubectl.kubernetes.io")
 		}),
+		CapacityBytes:           capacityBytes,
+		StorageClass:            vd.Status.StorageClassName,
+		PersistentVolumeClaim:   vd.Status.Target.PersistentVolumeClaim,
+		InUse:                   inUse,
+		AttachedVirtualMachines: attachedVMs,
+	}
+}
+
+func parseCapacityBytes(capacity string) int64 {
+	if capacity == "" {
+		return 0
+	}
+	q, err := resource.ParseQuantity(capacity)
+	if err != nil {
+		return 0
 	}
+	value, ok := q.AsInt64()
+	if !ok {
+		return 0
+	}
+	return value
+}
+
+func getInUseStatus(vd *v1alpha2.VirtualDisk) (bool, []string) {
+	inUseCond, found := conditions.GetCondition(vdcondition.InUseType, vd.Status.Conditions)
+	if !found {
+		return false, nil
+	}
+
+	if inUseCond.Status != metav1.ConditionTrue {
+		return false, nil
+	}
+
+	vmNames := make([]string, 0, len(vd.Status.AttachedToVirtualMachines))
+	for _, vm := range vd.Status.AttachedToVirtualMachines {
+		vmNames = append(vmNames, vm.Name)
+	}
+
+	return true, vmNames
 }

images/virtualization-artifact/pkg/monitoring/metrics/vd/metrics.go

@@ -23,9 +23,12 @@ import (
 )
 
 const (
-	MetricDiskStatusPhase = "virtualdisk_status_phase"
-	MetricDiskLabels      = "virtualdisk_labels"
-	MetricDiskAnnotations = "virtualdisk_annotations"
+	MetricDiskStatusPhase   = "virtualdisk_status_phase"
+	MetricDiskLabels        = "virtualdisk_labels"
+	MetricDiskAnnotations   = "virtualdisk_annotations"
+	MetricDiskCapacityBytes = "virtualdisk_capacity_bytes"
+	MetricDiskInfo          = "virtualdisk_info"
+	MetricDiskStatusInUse   = "virtualdisk_status_in_use"
 )
 
 var baseLabels = []string{"name", "namespace", "uid"}
@@ -68,4 +71,28 @@ var diskMetrics = map[string]metrics.MetricInfo{
 		WithBaseLabels(),
 		nil,
 	),
+
+	MetricDiskCapacityBytes: metrics.NewMetricInfo(
+		MetricDiskCapacityBytes,
+		"The virtualdisk capacity in bytes.",
+		prometheus.GaugeValue,
+		baseLabels,
+		nil,
+	),
+
+	MetricDiskInfo: metrics.NewMetricInfo(
+		MetricDiskInfo,
+		"Information about the virtualdisk.",
+		prometheus.GaugeValue,
+		WithBaseLabels("storageclass", "persistentvolumeclaim"),
+		nil,
+	),
+
+	MetricDiskStatusInUse: metrics.NewMetricInfo(
+		MetricDiskStatusInUse,
+		"Whether the virtualdisk is in use (1 - yes, 0 - no).",
+		prometheus.GaugeValue,
+		WithBaseLabels("virtualmachine"),
+		nil,
+	),
 }

images/virtualization-artifact/pkg/monitoring/metrics/vd/scraper.go

@@ -40,6 +40,9 @@ func (s *scraper) Report(m *dataMetric) {
 	s.updateMetricDiskStatusPhase(m)
 	s.updateMetricDiskLabels(m)
 	s.updateMetricDiskAnnotations(m)
+	s.updateMetricDiskCapacityBytes(m)
+	s.updateMetricDiskInfo(m)
+	s.updateMetricDiskStatusInUse(m)
 }
 
 func (s *scraper) updateMetricDiskStatusPhase(m *dataMetric) {
@@ -76,6 +79,24 @@ func (s *scraper) updateMetricDiskAnnotations(m *dataMetric) {
 	s.updateDynamic(MetricDiskAnnotations, 1, m, nil, m.Annotations)
 }
 
+func (s *scraper) updateMetricDiskCapacityBytes(m *dataMetric) {
+	s.defaultUpdate(MetricDiskCapacityBytes, float64(m.CapacityBytes), m)
+}
+
+func (s *scraper) updateMetricDiskInfo(m *dataMetric) {
+	s.defaultUpdate(MetricDiskInfo, 1, m, m.StorageClass, m.PersistentVolumeClaim)
+}
+
+func (s *scraper) updateMetricDiskStatusInUse(m *dataMetric) {
+	if m.InUse && len(m.AttachedVirtualMachines) > 0 {
+		for _, vmName := range m.AttachedVirtualMachines {
+			s.defaultUpdate(MetricDiskStatusInUse, 1, m, vmName)
+		}
+	} else {
+		s.defaultUpdate(MetricDiskStatusInUse, 0, m, "")
+	}
+}
+
 func (s *scraper) defaultUpdate(descName string, value float64, m *dataMetric, labels ...string) {
 	info := diskMetrics[descName]
 	metric, err := prometheus.NewConstMetric(