fix(vdsnapshot): resolve fsfreeze race condition #1668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hardcoretime
force-pushed
the
fix/vdsnapshot/freeze-request-race-condition
branch
13 times, most recently
from
dffed0c to
9065409
Compare
hardcoretime
requested review from
Isteb4k,
fl64 and
yaroslavborbat
as code owners
Isteb4k
requested changes
Nov 14, 2025
images/virtualization-artifact/pkg/common/annotations/annotations.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
hardcoretime
force-pushed
the
fix/vdsnapshot/freeze-request-race-condition
branch
2 times, most recently
from
e9dd407 to
1832bcf
Compare
Isteb4k
requested changes
Nov 18, 2025
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/watcher/kvvmi_watcher.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/service/snapshot_service.go
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
images/virtualization-artifact/pkg/controller/vdsnapshot/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
hardcoretime
force-pushed
the
fix/vdsnapshot/freeze-request-race-condition
branch
2 times, most recently
from
19b8743 to
1824066
Compare
added 3 commits
November 20, 2025 12:43
Signed-off-by: Roman Sysoev <[email protected]>
Use kvvmi status instead of vm. Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
added 18 commits
November 20, 2025 12:43
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
- add context to errors - watch kvvmi fsFreezeStatus instead of vm fsFrozenCondition - change freeze request annotation api group Signed-off-by: Roman Sysoev <[email protected]>
Signed-off-by: Roman Sysoev <[email protected]>
hardcoretime
force-pushed
the
fix/vdsnapshot/freeze-request-race-condition
branch
from
1824066 to
3628c19
Compare
Signed-off-by: Isteb4k <[email protected]>
Isteb4k
previously approved these changes
Nov 20, 2025
Signed-off-by: Roman Sysoev <[email protected]>
Isteb4k
approved these changes
Nov 21, 2025
hardcoretime
deleted the
fix/vdsnapshot/freeze-request-race-condition
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
Sometimes, when the virtual disk snapshot controller creates a batch of snapshots with required consistency, a race condition in the freeze or unfreeze filesystem operation can cause an inconsistent snapshot. To prevent this, the KubeVirt virtual machine instance is now annotated with a "freeze" or "unfreeze" request, and the service checks that the type of this request matches the
fsFreezeStatus. ThefsFreezeStatusis considered trusted only if it matches the request type.What is the expected result?
Snapshots with required consistency now execute without race conditions in the filesystem freeze process.
Checklist
Changelog entries