Skip to content

feat(vd): enable storage class migration for hotplugged disks #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
loktev-d wants to merge 6 commits into
base: feat/vmop/enable-hotplug-local-disk-migration
Choose a base branch
from
Open

feat(vd): enable storage class migration for hotplugged disks #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f6f5c72
wip
loktev-d Dec 3, 2025
70d0549
Merge remote-tracking branch 'origin/feat/vmop/enable-hotplug-local-d…
loktev-d Dec 3, 2025
366c173
wip
loktev-d Dec 9, 2025
8971b82
wip
loktev-d Dec 9, 2025
92f5526
wip
loktev-d Dec 10, 2025
9926a39
wip
loktev-d Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion images/virtualization-artifact/pkg/controller/kvbuilder/kvvm_utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,8 +257,14 @@ func ApplyVirtualMachineSpec(

switch {
case device.PVCName != "":
pvcName := device.PVCName
if kind == v1alpha2.DiskDevice {
if vd := vdByName[name]; vd != nil && vd.Status.Target.PersistentVolumeClaim != "" {
pvcName = vd.Status.Target.PersistentVolumeClaim
}
}
if err := kvvm.SetDisk(device.VolumeName, SetDiskOptions{
PersistentVolumeClaim: pointer.GetPointer(device.PVCName),
PersistentVolumeClaim: pointer.GetPointer(pvcName),
IsHotplugged: true,
Serial: GenerateSerialFromObject(obj),
}); err != nil {
Expand Down
6 changes: 0 additions & 6 deletions ...s/virtualization-artifact/pkg/controller/vd/internal/validator/storage_class_validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,12 +125,6 @@ func (v *StorageClassValidator) validateTargetStorageClassForVolumeMigration(ctx
return fmt.Errorf("storage class cannot be changed unless the VirtualDisk is mounted to a running virtual machine")
}

for _, bd := range vm.Status.BlockDeviceRefs {
if bd.Hotplugged {
return fmt.Errorf("for now, changing the storage class is not allowed if the virtual machine has hot-plugged block devices")
}
}

currentStorageClassName := newVD.Status.StorageClassName
currentStorageClass, err := v.scService.GetStorageClass(ctx, currentStorageClassName)
if err != nil {
Expand Down
Loading