Skip to content

chore(api): extend core fraction validation error msg #1793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hardcoretime merged 3 commits into from
Dec 11, 2025
Merged

chore(api): extend core fraction validation error msg #1793

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
537ea4c
chore(api): extend core fraction validation error msg
Dec 5, 2025
eff3973
chore(api): format core fraction values in err msg
Dec 9, 2025
e555918
chore(api): use CutSuffix and improve err msg
Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
80 changes: 50 additions & 30 deletions images/virtualization-artifact/pkg/controller/service/size_policy_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,14 +28,15 @@ import (
"github.com/deckhouse/virtualization/api/core/v1alpha2"
)

var ErrSizingPolicyValidation = errors.New("please check the sizing policy of the virtual machine class or contact the administrator for more information")

type SizePolicyService struct{}

func NewSizePolicyService() *SizePolicyService {
return &SizePolicyService{}
}

func (s *SizePolicyService) CheckVMMatchedSizePolicy(vm *v1alpha2.VirtualMachine, vmClass *v1alpha2.VirtualMachineClass) error {
// check if no sizing policy requirements are set
if vmClass == nil || len(vmClass.Spec.SizingPolicies) == 0 {
return nil
}
Expand All @@ -45,14 +46,25 @@ func (s *SizePolicyService) CheckVMMatchedSizePolicy(vm *v1alpha2.VirtualMachine
return NewNoSizingPolicyMatchError(vm.Name, vm.Spec.VirtualMachineClassName)
}

var errorsArray []error
var errs []error

errorsArray = append(errorsArray, validateCoreFraction(vm, sizePolicy)...)
errorsArray = append(errorsArray, validateMemory(vm, sizePolicy)...)
errorsArray = append(errorsArray, validatePerCoreMemory(vm, sizePolicy)...)
err := validateCoreFraction(vm, sizePolicy)
if err != nil {
errs = append(errs, err)
}

if len(errorsArray) > 0 {
return fmt.Errorf("sizing policy validate: %w", errors.Join(errorsArray...))
err = validateMemory(vm, sizePolicy)
if err != nil {
errs = append(errs, err)
}

err = validatePerCoreMemory(vm, sizePolicy)
if err != nil {
errs = append(errs, err)
}

if len(errs) > 0 {
return fmt.Errorf("sizing policy validation has failed: %w: %w", errors.Join(errs...), ErrSizingPolicyValidation)
}

return nil
Expand All @@ -72,16 +84,15 @@ func getVMSizePolicy(vm *v1alpha2.VirtualMachine, vmClass *v1alpha2.VirtualMachi
return nil
}

func validateCoreFraction(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolicy) (errorsArray []error) {
func validateCoreFraction(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolicy) error {
if len(sp.CoreFractions) == 0 {
return
return nil
}

fractionStr := strings.ReplaceAll(vm.Spec.CPU.CoreFraction, "%", "")
fractionStr, _ := strings.CutSuffix(vm.Spec.CPU.CoreFraction, "%")
fraction, err := strconv.Atoi(fractionStr)
if err != nil {
errorsArray = append(errorsArray, fmt.Errorf("unable to parse CPU core fraction: %w", err))
return
return fmt.Errorf("unable to parse CPU core fraction: %w", err)
}

hasFractionValueInPolicy := false
Expand All @@ -92,33 +103,34 @@ func validateCoreFraction(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolicy
}

if !hasFractionValueInPolicy {
errorsArray = append(errorsArray, fmt.Errorf("VM core fraction value %d is not within the allowed values", fraction))
formattedCoreFractions := formatCoreFractionValues(sp.CoreFractions)
return fmt.Errorf("VM core fraction value %s is not within the allowed values: %v", vm.Spec.CPU.CoreFraction, formattedCoreFractions)
}

return
return nil
}

func validateMemory(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolicy) (errorsArray []error) {
func validateMemory(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolicy) error {
if sp.Memory == nil || sp.Memory.Max == nil || sp.Memory.Max.IsZero() {
return
return nil
}

if sp.Memory.Min != nil && vm.Spec.Memory.Size.Cmp(*sp.Memory.Min) == common.CmpLesser {
errorsArray = append(errorsArray, fmt.Errorf(
return fmt.Errorf(
"requested VM memory (%s) is less than the minimum allowed, available range [%s, %s]",
vm.Spec.Memory.Size.String(),
sp.Memory.Min.String(),
sp.Memory.Max.String(),
))
)
}

if vm.Spec.Memory.Size.Cmp(*sp.Memory.Max) == common.CmpGreater {
errorsArray = append(errorsArray, fmt.Errorf(
return fmt.Errorf(
"requested VM memory (%s) exceeds the maximum allowed, available range [%s, %s]",
vm.Spec.Memory.Size.String(),
sp.Memory.Min.String(),
sp.Memory.Max.String(),
))
)
}

if sp.Memory.Step != nil && !sp.Memory.Step.IsZero() {
Expand All @@ -128,16 +140,16 @@ func validateMemory(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolicy) (err
}
err := validateIsQuantized(vm.Spec.Memory.Size, minVal, *sp.Memory.Max, *sp.Memory.Step, "VM memory")
if err != nil {
errorsArray = append(errorsArray, err)
return err
}
}

return
return nil
}

func validatePerCoreMemory(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolicy) (errorsArray []error) {
func validatePerCoreMemory(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolicy) error {
if sp.Memory == nil || sp.Memory.PerCore == nil || sp.Memory.PerCore.Max == nil || sp.Memory.PerCore.Max.IsZero() {
return
return nil
}

// Calculate memory portion per CPU core
Expand All @@ -147,21 +159,21 @@ func validatePerCoreMemory(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolic
perCoreMemory := resource.NewQuantity(vmPerCore, resource.BinarySI)

if sp.Memory.PerCore.Min != nil && perCoreMemory.Cmp(*sp.Memory.PerCore.Min) == common.CmpLesser {
errorsArray = append(errorsArray, fmt.Errorf(
return fmt.Errorf(
"requested VM per core memory (%s) is less than the minimum allowed, available range [%s, %s]",
perCoreMemory.String(),
sp.Memory.PerCore.Min.String(),
sp.Memory.PerCore.Max.String(),
))
)
}

if perCoreMemory.Cmp(*sp.Memory.PerCore.Max) == common.CmpGreater {
errorsArray = append(errorsArray, fmt.Errorf(
return fmt.Errorf(
"requested VM per core memory (%s) exceeds the maximum allowed, available range [%s, %s]",
perCoreMemory.String(),
sp.Memory.PerCore.Min.String(),
sp.Memory.PerCore.Max.String(),
))
)
}

if sp.Memory.Step != nil && !sp.Memory.Step.IsZero() {
Expand All @@ -171,11 +183,11 @@ func validatePerCoreMemory(vm *v1alpha2.VirtualMachine, sp *v1alpha2.SizingPolic
}
err := validateIsQuantized(*perCoreMemory, minVal, *sp.Memory.PerCore.Max, *sp.Memory.Step, "VM per core memory")
if err != nil {
errorsArray = append(errorsArray, err)
return err
}
}

return
return nil
}

func validateIsQuantized(value, min, max, step resource.Quantity, source string) (err error) {
Expand Down Expand Up @@ -212,3 +224,11 @@ func generateValidGrid(min, max, step resource.Quantity) []resource.Quantity {

return grid
}

func formatCoreFractionValues(cf []v1alpha2.CoreFractionValue) []string {
result := make([]string, len(cf))
for i, v := range cf {
result[i] = fmt.Sprintf("%d%%", v)
}
return result
}
Loading