Skip to content

feat(vmop): add type for d8_virtualization_virtualmachineoperation_st… #1803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danilrwx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(vmop): add type for d8_virtualization_virtualmachineoperation_st… #1803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions images/virtualization-artifact/pkg/monitoring/metrics/vmop/data_metric.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ type dataMetric struct {
Name string
Namespace string
UID string
Type string
Phase v1alpha2.VMOPPhase
}

Expand All @@ -36,5 +37,6 @@ func newDataMetric(vmop *v1alpha2.VirtualMachineOperation) *dataMetric {
Namespace: vmop.Namespace,
UID: string(vmop.UID),
Phase: vmop.Status.Phase,
Type: string(vmop.Spec.Type),
}
}
3 changes: 2 additions & 1 deletion images/virtualization-artifact/pkg/monitoring/metrics/vmop/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const (
MetricVMOPStatusPhase = "virtualmachineoperation_status_phase"
)

var baseLabels = []string{"name", "namespace", "uid"}
var baseLabels = []string{"name", "namespace", "uid", "type"}

func WithBaseLabels(labels ...string) []string {
return append(baseLabels, labels...)
Expand All @@ -39,6 +39,7 @@ func WithBaseLabelsByMetric(m *dataMetric, labels ...string) []string {
m.Name,
m.Namespace,
m.UID,
m.Type,
}
}
return append(base, labels...)
Expand Down
Loading