Replace the old redis cache implementation #858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
azisaka
force-pushed
the
feat/redis-cache
branch
2 times, most recently
from
05c046a to
44a55a5
Compare
mcandeia
requested changes
Oct 7, 2024
mcandeia
requested changes
Oct 8, 2024
mcandeia
requested changes
Oct 8, 2024
mcandeia
requested changes
Oct 9, 2024
azisaka
force-pushed
the
feat/redis-cache
branch
from
8c97643 to
dd0042a
Compare
mcandeia
approved these changes
Oct 10, 2024
I created a new version of the Redis cache engine. Currently it supports the put, match and delete methods. The connection and methods will not block the load of the pages. It was made to also support reconnection on failure; and even during a failure the website will keep running until the connection gets healthy again. When an error occurs, the connection will be halted on purpose. Just like a open circuit breaker. The idea is to not fall into a reconnection loop. Once the website tries to cache again, the engine will try to reconnect. Co-authored-by: Marcos Candeia <[email protected]>
azisaka
force-pushed
the
feat/redis-cache
branch
from
b7529c6 to
526fe52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a new version of the Redis cache engine.
Currently it supports the put, match and delete methods. The connection and methods will not block the load of the pages.
It was made to also support reconnection on failure; and even during a failure the website will keep running until the connection gets healthy again.
When an error occurs, the connection will be halted on purpose. Just like a open circuit breaker. The idea is to not fall into a reconnection loop. Once the website tries to cache again, the engine will try to reconnect.