useScript breaking when called in the browser #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tagging OptionsShould a new tag be published when this PR is merged?
|
|
Some things to note here:
Makes me conclude that this should be solved via you app's code; unless we do something like a dynamic import checming for window or something along these lines. |
|
useScript must fail if run in client side. Its a server side only thing to do. Maybe you can give a warning and don't run it on client side instead. |
matheusgr
requested changes
Nov 26, 2024
| import { LRUCache } from "npm:[email protected]"; | ||
| import { minify as terserMinify } from "npm:[email protected]"; | ||
|
|
||
| const verbose = !!Deno.env.get("SCRIPT_MINIFICATION_DEBUG"); | ||
| const verbose = !IS_BROWSER && !!Deno.env.get("SCRIPT_MINIFICATION_DEBUG"); |
There was a problem hiding this comment.
I believe that this function should not run client side.
Maybe if it is run at clientSide, throw an exception and stop it execution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked that
Denois not called on the client side.