Fail fast on batched feature intervention inputs#89
Open
Sohailm25 wants to merge 1 commit intodecoderesearch:mainfrom
Open
Fail fast on batched feature intervention inputs#89Sohailm25 wants to merge 1 commit intodecoderesearch:mainfrom
Sohailm25 wants to merge 1 commit intodecoderesearch:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
While following up on #67, I found that the intervention paths are still fundamentally single-sequence internally, but batched inputs are not rejected cleanly. For example, batched tensor input to feature_intervention(...) currently falls through into the delta code and raises a cryptic internal error like
ValueError: too many values to unpack (expected 2).This PR does not claim to add batch intervention support. Instead, it makes the current contract explicit and fails fast with a clear message, which is safer for users and easier to debug.
Testing
Related to #67