secp256k1/schnorr: Expose signature r and s. #3437
Merged
+30
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthawkins90
approved these changes
Sep 4, 2024
martonp
approved these changes
Sep 5, 2024
jrick
approved these changes
Sep 5, 2024
This exposes the R and S values of schnorr signatures in the same way they are exposed for ECDSA signatures. The R and S values are useful for various computations and currently there is currently no easy and efficient way for external consumers to get the values.
This adds a couple of additional checks to the sign and verify tests to ensure the new R and S methods return the expected values.
davecgh
force-pushed
the
secp256k1_expose_schnorr_rs
branch
from
76cc056
to
02b1cff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes the
RandSvalues of Schnorr signatures in the same way they are exposed for ECDSA signatures.The
RandSvalues are useful for various computations and currently there is currently no easy and efficient way for external consumers to get the values.It also adds some additional checks to the sign and verify tests to ensure the new methods return the expected values.