Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Update image to golang:1.23.1-alpine3.20. #3440

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

davecgh
Copy link
Member

@davecgh davecgh commented Sep 6, 2024

This updates the docker image to golang:1.23.1-alpine3.20.

To confirm the new digest:

$ docker pull golang:1.23.1-alpine3.20
1.23.1-alpine3.20: Pulling from library/golang
...
Digest: sha256:ac67716dd016429be8d4c2c53a248d7bcdf06d34127d3dc451bda6aa5a87bc06
...

@davecgh davecgh added this to the 2.1.0 milestone Sep 6, 2024
Copy link
Member

@jholdstock jholdstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am seeing a different value:

1.23.1-alpine3.20: Pulling from library/golang
Digest: sha256:7ed3ee46b57ffc90cc32b50c7d5f40b2bd452d2dc97e42d6e9da47067f266ef4
Status: Image is up to date for golang:1.23.1-alpine3.20
docker.io/library/golang:1.23.1-alpine3.20

@davecgh
Copy link
Member Author

davecgh commented Sep 7, 2024

Thanks for double checking! I'll wait a couple of days and pull again. I waited a day already to let it stabilize, but looks like it wasn't long enough.

@jrick
Copy link
Member

jrick commented Sep 7, 2024

does anyone have any idea how these images differ?

this seems to come up every time a new go version comes out

@davecgh
Copy link
Member Author

davecgh commented Sep 7, 2024

It happens because the builds are still ongoing and they're multi-platform image builds. So, every time a new arch/plat pair gets done building, the image index hash changes even though the actual linux/amd64 image we use doesn't change.

You can see it by comparing the e.g. linux/amd64 and linux/386 and noting the "Index digest" at the top is the same.

It's kind of annoying that Docker does it that way and I don't really know why it does since I've never really followed it very much, but I suspect it's because it originally did not support multi-platform builds and support for them was probably shoehorned into the already existing ecosystem that relied on them by that point.

This updates the docker image to golang:1.23.1-alpine3.20.

To confirm the new digest:

```
$ docker pull golang:1.23.1-alpine3.20
1.23.1-alpine3.20: Pulling from library/golang
...
Digest: sha256:ac67716dd016429be8d4c2c53a248d7bcdf06d34127d3dc451bda6aa5a87bc06
...
```
@davecgh
Copy link
Member Author

davecgh commented Sep 9, 2024

I've updated this to the latest. It looks like all of the builds are done now as the latest hash hasn't changed in a couple of days.

@davecgh davecgh merged commit f3d7099 into decred:master Sep 10, 2024
2 checks passed
@davecgh davecgh deleted the contrib_docker_go1_23_1 branch September 10, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants