Firo light wallet (electrum) support #2426

dev-warrior777 · 2023-07-04T14:27:10Z

Firo light wallet (electrum) support

JoeGruffins

Oh wow, does this add an electrum server for simnet? That's great! Can we also do that for the other electrum capable wallets? Not in this pr ofc.

There is an empty file recycled-addrs.txt if something is creating that maybe add to .gitignore?

dex/testing/firo/electrum.sh

dex/testing/firo/electrumx.sh

dev-warrior777 · 2023-07-05T06:59:53Z

ElectrumX servers

Does this add an electrum server for simnet?

Yes, I think the dex/testing electrumX server code was mostly there or thereabouts for bitcoin but I did a Firo one as bitcoin electrum/electrumX is sufficiently different.

Can we also do that for the other electrum capable wallets?

I already did for Dash on my local machine and have my own fork of the server. But please look at the discussion of electrum Wallets below

Electrum wallets

I did the whole electrum piece because Firo does not yet have SPV wallet support (P2P) as it is lower on the priority list than Lelantus Spark and other multi year ZKP improvements. So an electrum 'SPV' wallet that would not require chain download would increase UX a lot! I would expect this to be the main (non OTC) wallet perhaps

Then I looked at all the other electrum-altcoin implementations.

I think BCH is possible. It was partly implemented in dex although currently commented out (client bch.go) I have run BCH one and there are electrumX servers but I did not get deep into the python yet although a quick glance shows some BCH-specific stuff in commands.py. However BCH already has (P2P) SPV so I guess not urgent/useful
Dash is kinda the opposite:
- It is quite old. The original archived one is still python 2.7. Although it was updated to python3 and maintained in Ukraine. Those guys deleted the github totally and just have anti russian statements there. But it is maintained since last year by a semi-official fork of that code. The maintainer currently over busy though.
- Another mainstream Dash dev has also just updated the C-python X11 hash algo for electrumX / electrum to work with python >= 3.10 so I think they still care.
- But I see only one reliable mainnet Dash electrumX server - they had I think 5 some years back. So not sure the usage of Dash electrum today. I am working with one guy at Dash to research current usage / need for electrumX servers.
Doge .. not touched for 9 years ;-) doubt if it works, don't care also

dev-warrior777 · 2023-07-05T07:22:39Z

There is an empty file recycled-addrs.txt if something is creating that maybe add to

This is a function of another recent PR for recycling unused redemption and refund addresses and seems to create a directory where code is run and a file with recycled-addrs.txt. This happens when I run simnet tests in client/asset/... but I am not sure where else it would pop up (as testnet/mainnet/regtest) so not sure the extent of .gitignore

Including that particular one in my check-in is my bad and I will remove it ;-)

Removed

dev-warrior777 · 2023-07-05T07:43:13Z

Thanks for your review and your interest.

JoeGruffins · 2023-07-05T08:19:25Z

Slightly unrelated, but testing litecoin's electrum client on testnet is an pain in the butt because the servers are all over the place on different states of the chain. Would be much better testing on simnet, so this pr is exciting for me. Will test this out soon.

dev-warrior777 · 2023-07-05T08:29:11Z

Slightly unrelated, but testing litecoin's electrum client on testnet is an pain in the butt because the servers are all over the place on different states of the chain. Would be much better testing on simnet, so this pr is exciting for me. Will test this out soon.

For Firo I have another test that tests basic ElectrumX command API. It tests one (real) mainnet server and one (real) testnet server plus simnet server on demand (set environment var) In the same place: dex/dcrdex/dex/testing/firo/test/electrumx_network_test.go. Again I updated a bitcoin test for this. You could test simnet server with server specific non-dex code as well as checking real servers

dex/testing/firo/test/README.md checked in

dev-warrior777 · 2023-07-05T10:15:57Z

Newer README's / scripts

chappjc · 2023-07-05T14:33:53Z

Slightly unrelated, but testing litecoin's electrum client on testnet is an pain in the butt because the servers are all over the place on different states of the chain. Would be much better testing on simnet, so this pr is exciting for me. Will test this out soon.

LTC already had electrum(x) regtest stuff I think. What new?

dev-warrior777 · 2023-07-05T14:37:25Z

LTC already had electrum(x) regtest stuff I think. What new?

Yes. I copied it and just modify for Firo.
Bitcoin/LTC too different to put in same script

JoeGruffins · 2023-07-06T02:54:48Z

LTC already had electrum(x) regtest stuff I think. What new?

Oh! You are right. How did I miss that... a3dac7e

Hmm, I guess I knew and forgot. I'm getting old, srry #1607

dex/testing/firo/harness.sh

dex/testing/firo/README_HARNESS.md

dex/testing/firo/electrumx.sh

dex/testing/firo/electrum.sh

JoeGruffins

Working well for me!

dex/testing/firo/README_ELECTRUM_HARNESSES.md

client/asset/firo/firo.go

dex/testing/firo/README_ELECTRUM_HARNESSES.md

client/asset/firo/firo.go

dev-warrior777 · 2023-07-10T14:47:50Z

Working well for me!

Great to hear!

client/asset/firo/firo.go

client/core/simnet_trade.go

dex/testing/firo/README_ELECTRUM_HARNESSES.md

dex/testing/firo/electrumx.sh

dex/testing/firo/harness.sh

dex/testing/firo/test/README.md

dev-warrior777 · 2023-07-10T18:33:21Z

Added a compile check in run_tests.sh

...
go test -c -o /dev/null -tags harness ./client/asset/bch
go test -c -o /dev/null -tags harness ./client/asset/firo
go test -c -o /dev/null -tags harness ./client/asset/eth
...

client/asset/firo/firo.go

dex/testing/firo/README_ELECTRUM_HARNESSES.md

dex/testing/firo/electrumx.sh

dex/testing/firo/electrum.sh

buck54321 · 2023-08-25T19:11:12Z

dex/testing/firo/stop-daemon

Are GUI and daemon the only options. No standard terminal mode?

Not quite sure what you mean by standard terminal mode. But I think the answer to your question is - only these two modes yes.

For startup the script is electrum-firo and --daemon takes it down the non-gui code path. But you can also run the script with something like:
./electrum-firo -v --offline --testnet listunspent
which will access the testnet wallet, ask password, then output all the listunspent utxos; then exit

I'm asking if we make electrum block and log to the terminal. I don't want it to run as a daemon.

dex/testing/firo/electrum.sh

dev-warrior777 · 2023-08-26T19:04:57Z

I cannot find any of the chappjc requested changes below that I have not addressed. Maybe a github glitch?

dev-warrior777 · 2023-08-26T19:28:17Z

For your ref: Updated everything requested except the development zombie killer. Thanks

buck54321

Tested on simnet and testnet. Working great. Almost ready.

client/asset/firo/firo.go

buck54321 · 2023-08-27T13:51:21Z

dex/testing/firo/README_HARNESS.md

+```bash
+$   killall -9 firod                    # kill running daemons
+$   tmux kill-session -t firo-harness   # kill firo-harness session
+```


No pid file needed. There are a number of ways to figure out the pid of a zombie instance. People reading this document are expected to have some level of technical knowledge. We don't need to babysit here.

buck54321 · 2023-08-27T13:54:45Z

dex/testing/firo/stop-daemon

I'm asking if we make electrum block and log to the terminal. I don't want it to run as a daemon.

buck54321 · 2023-08-27T13:59:12Z

dex/testing/firo/README_ELECTRUM_HARNESSES.md

+$  ./run dcrfiroelectrum --runonce --all
+```
+
+Best results by nuking everything after each run.


Our various scripts should be nuking everything during setup, no?

dev-warrior777 · 2023-08-28T09:59:28Z

I have updated the livetest code & updated the docs.

For your questions:

Our various scripts should be nuking everything during setup, no?

When the harnesses start Yes
What I mean't was don't run the simnet-trade-test suite twice with the same harnesses. They can run out of coins. Any on the fly restarts of one harness can make harnesses not in sync w.r.t underlying regtest/simnet chain blocks, transactions, height, etc. This is especially true for electrumX and the regtest chain it is proxying.

It is not a must but can be a source of error.

I'm asking if we make electrum block and log to the terminal. I don't want it to run as a daemon.

CLI

./electrum-firo daemon -v --testnet

This is what you want. It is electrum daemon/rpc mode but does not fork the child process like the true daemon below.

Use -v for debug logging to stderr

True Daemon

./electrum-firo daemon --detach --testnet

Default startup is CLI but starting with STARTUP="GUI" installs pyqt5 & starts the wallet Gui. Starting with STARTUP="DAEMON" forks the process.

dev-warrior777 marked this pull request as ready for review July 4, 2023 14:40

JoeGruffins reviewed Jul 5, 2023

View reviewed changes

dex/testing/firo/electrum.sh Outdated Show resolved Hide resolved

dex/testing/firo/electrumx.sh Outdated Show resolved Hide resolved

JoeGruffins reviewed Jul 7, 2023

View reviewed changes

dex/testing/firo/harness.sh Show resolved Hide resolved

dex/testing/firo/README_HARNESS.md Outdated Show resolved Hide resolved

dex/testing/firo/electrumx.sh Outdated Show resolved Hide resolved

dex/testing/firo/electrum.sh Show resolved Hide resolved

dev-warrior777 requested a review from JoeGruffins July 9, 2023 07:38

JoeGruffins approved these changes Jul 10, 2023

View reviewed changes

dex/testing/firo/README_ELECTRUM_HARNESSES.md Show resolved Hide resolved

client/asset/firo/firo.go Show resolved Hide resolved

dex/testing/firo/README_ELECTRUM_HARNESSES.md Outdated Show resolved Hide resolved

client/asset/firo/firo.go Outdated Show resolved Hide resolved

chappjc requested changes Jul 10, 2023

View reviewed changes

dev-warrior777 force-pushed the electrum_firo branch from b028ec1 to 7a8fd9e Compare July 22, 2023 17:34

buck54321 requested changes Aug 25, 2023

View reviewed changes

xorzero777 added 7 commits August 26, 2023 17:03

Firo light wallet (electrum) support

8761d92

dex/testing: Update Firo electrum scripts and docs

aa43aab

dex/testing: Firo electrum scripts and docs - post review

6eda053

client,testing: Update comments and docs

0cfa614

client,dex/testing: Code & script improvements

bf97d0f

dex/testing: Clean up markdown

13388da

dex/testing: Start regtest electrum as daemon by default

4cc0e9a

electrum:firo: Changes for review

12b975e

dev-warrior777 force-pushed the electrum_firo branch from 7a8fd9e to 12b975e Compare August 26, 2023 19:21

buck54321 requested changes Aug 27, 2023

View reviewed changes

electrum:firo: further review changes

1297ebc

electrum:firo: Start electrum wallet as CLI server.

86587b8

Default startup is CLI but starting with STARTUP="GUI" installs pyqt5 & starts the wallet Gui. Starting with STARTUP="DAEMON" forks the process.

buck54321 approved these changes Aug 31, 2023

View reviewed changes

buck54321 merged commit 3f8b0fe into decred:master Aug 31, 2023

dev-warrior777 deleted the electrum_firo branch September 1, 2023 00:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Firo light wallet (electrum) support #2426

Firo light wallet (electrum) support #2426

dev-warrior777 commented Jul 4, 2023

JoeGruffins left a comment

dev-warrior777 commented Jul 5, 2023 •

edited

Loading

dev-warrior777 commented Jul 5, 2023 •

edited

Loading

dev-warrior777 commented Jul 5, 2023

JoeGruffins commented Jul 5, 2023

dev-warrior777 commented Jul 5, 2023 •

edited

Loading

dev-warrior777 commented Jul 5, 2023 •

edited

Loading

chappjc commented Jul 5, 2023

dev-warrior777 commented Jul 5, 2023

JoeGruffins commented Jul 6, 2023 •

edited

Loading

JoeGruffins left a comment

dev-warrior777 commented Jul 10, 2023

dev-warrior777 commented Jul 10, 2023

buck54321 Aug 25, 2023

dev-warrior777 Aug 26, 2023

buck54321 Aug 27, 2023

dev-warrior777 commented Aug 26, 2023 •

edited

Loading

dev-warrior777 commented Aug 26, 2023

buck54321 left a comment

buck54321 Aug 27, 2023

buck54321 Aug 27, 2023

buck54321 Aug 27, 2023

dev-warrior777 commented Aug 28, 2023

Firo light wallet (electrum) support #2426

Firo light wallet (electrum) support #2426

Conversation

dev-warrior777 commented Jul 4, 2023

JoeGruffins left a comment

Choose a reason for hiding this comment

dev-warrior777 commented Jul 5, 2023 • edited Loading

ElectrumX servers

Electrum wallets

dev-warrior777 commented Jul 5, 2023 • edited Loading

dev-warrior777 commented Jul 5, 2023

JoeGruffins commented Jul 5, 2023

dev-warrior777 commented Jul 5, 2023 • edited Loading

dev-warrior777 commented Jul 5, 2023 • edited Loading

chappjc commented Jul 5, 2023

dev-warrior777 commented Jul 5, 2023

JoeGruffins commented Jul 6, 2023 • edited Loading

JoeGruffins left a comment

Choose a reason for hiding this comment

dev-warrior777 commented Jul 10, 2023

dev-warrior777 commented Jul 10, 2023

buck54321 Aug 25, 2023

Choose a reason for hiding this comment

dev-warrior777 Aug 26, 2023

Choose a reason for hiding this comment

buck54321 Aug 27, 2023

Choose a reason for hiding this comment

dev-warrior777 commented Aug 26, 2023 • edited Loading

dev-warrior777 commented Aug 26, 2023

buck54321 left a comment

Choose a reason for hiding this comment

buck54321 Aug 27, 2023

Choose a reason for hiding this comment

buck54321 Aug 27, 2023

Choose a reason for hiding this comment

buck54321 Aug 27, 2023

Choose a reason for hiding this comment

dev-warrior777 commented Aug 28, 2023

dev-warrior777 commented Jul 5, 2023 •

edited

Loading

dev-warrior777 commented Jul 5, 2023 •

edited

Loading

dev-warrior777 commented Jul 5, 2023 •

edited

Loading

dev-warrior777 commented Jul 5, 2023 •

edited

Loading

JoeGruffins commented Jul 6, 2023 •

edited

Loading

dev-warrior777 commented Aug 26, 2023 •

edited

Loading