-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: use average rate for market order rate display #2463
multi: use average rate for market order rate display #2463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it too. The match card does not update until I refresh the page, and then the rate shows. |
Just open a buy limit order then open a market sell. |
9bede4e
to
7c27a0b
Compare
3668440
to
a76f473
Compare
I'm unable to reproduce this @martonp, Is anyone else seeing this? |
Screen.Recording.2023-08-22.at.8.28.46.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d265f2b
to
89b6712
Compare
Ready but needs a rebase. |
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
…e HTMLElement Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
@buck54321, do you want me to squash? |
Signed-off-by: Philemon Ukane <[email protected]>
89b6712
to
cfb036a
Compare
Nah. I'll squash when I merge. |
The rate display for market orders on the
orders
,order
and 'market'(on the "user-order card") page, including theActual Rate
field when exporting a market order, will use the average order rate instead of just zero ormarket
. Closes #1969.