mm: Handle market params update#2846
Merged
buck54321 merged 3 commits intodecred:masterfrom Mar 26, 2025
Merged
Conversation
JoeGruffins
approved these changes
Jun 27, 2024
martonp
force-pushed
the
mktParamsUpdate
branch
2 times, most recently
from
0863701 to
3e8478c
Compare
buck54321
reviewed
Nov 18, 2024
buck54321
requested changes
Mar 22, 2025
Member
buck54321
left a comment
buck54321
left a comment
There was a problem hiding this comment.
Just one suggestion and a rebase.
This diff updates the market maker to listen for updates to the server config. If the lot size of a market that a bot is currently trading on is updated, the number of placements that the bot makes is updated so that the bot places as many lots as possible without exceeding the amount that was placed before the lot size update.
martonp
force-pushed
the
mktParamsUpdate
branch
from
b6ae4f4 to
ceb99b3
Compare
buck54321
approved these changes
Mar 26, 2025
martonp
added a commit
to martonp/dcrdex
that referenced
this pull request
May 7, 2025
* mm: Handle market params update This diff updates the market maker to listen for updates to the server config. If the lot size of a market that a bot is currently trading on is updated, the number of placements that the bot makes is updated so that the bot places as many lots as possible without exceeding the amount that was placed before the lot size update. * Review updates * Reivew updates
martonp
added a commit
to martonp/dcrdex
that referenced
this pull request
Jul 8, 2025
* mm: Handle market params update This diff updates the market maker to listen for updates to the server config. If the lot size of a market that a bot is currently trading on is updated, the number of placements that the bot makes is updated so that the bot places as many lots as possible without exceeding the amount that was placed before the lot size update. * Review updates * Reivew updates
buck54321
pushed a commit
that referenced
this pull request
Jul 26, 2025
* mm: Handle market params update This diff updates the market maker to listen for updates to the server config. If the lot size of a market that a bot is currently trading on is updated, the number of placements that the bot makes is updated so that the bot places as many lots as possible without exceeding the amount that was placed before the lot size update. * Review updates * Reivew updates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This diff updates the market maker to listen for updates to the server config. If the lot size of a market that a bot is currently trading on is updated, the number of placements that the bot makes is updated so that the bot places as many lots as possible without exceeding the amount that was placed before the lot size update.
Additionally, the lot size is now saved with the
BotConfig. An additionaloverrideLotSizeChangeparameter is added toStartBot, which if false, will return an error if the lot size has changed since the bot was configured. This will allow the UI to prompt the user to either update their configuration, or continue with the old one even though the lot size has changed.