client,webserver: Use the app build version as Version in UI. #3096
Conversation
|
master: c298ca2
|
- Use the value from client/app/version.go - Place at the foot of Settings dialog - Re-purpose 'BUILD ID' as "Version for translations and find relevant translations
- Also replaced the deleted Doc.bind 'Add Dex'
| @@ -257,7 +257,7 @@ | |||
| </div> | |||
| </div> | |||
|
|
|||
| <script src="/js/entry.js?v={{commitHash}}"></script> | |||
| <script src="/js/entry.js"></script> | |||
There was a problem hiding this comment.
I think this needed in order to avoid the browser returning a previous version of the js that was cached.
There was a problem hiding this comment.
Ok .. I am not that great with js .. but the variable commitHash has been removed. I did test quite a bit after making the above change.
Is this part ?v={{commitHash}} used as like an Id or a marker? Would a one-time randomly generated number do instead perhaps .. like always use ... /js/entry.js?v=1234567 maybe? And similarly for the link in the header: <link href="/css/style.css?v={{commitHash}}" rel="stylesheet"> at the top of the page
There was a problem hiding this comment.
And maybe the build itself can now create the entry.js, entry.js.map?
There was a problem hiding this comment.
Is this part ?v={{commitHash}} used as like an Id or a marker?
Yes, without this, if you check out a different version and run the UI, you will see the previous version of the js and css that were cached.
I think you should just leave the commitHash template func and not change this stuff.
There was a problem hiding this comment.
Now using Webpack Build ID in place of commitHash
Also: - Translation string 'BUILD ID' is no longer used. - 'BUILD ID' => 'Version' - Translations updated to mean Version - not Build Id. except arabic as I cannot handle the input method to edit arabic as the arrow/BS keys go the wrong way in the editor. And I do not understand how the editor concatenates arabic strings. Meaning left as previously translated: Build Id.
dev-warrior777
force-pushed
the
version
branch
from
5d87755 to
83d7766
Compare
- Emit a webpack build ID when building site and store in webpack-build-id.txt - Embed the webpack build ID into bodybuilder as a url query string:- webpackBuildIdQuery fetches latest webpack build from the webpack-build-id.txt file in app site directory and makes it available to append to the main css link and to the main script link in bodybuilder; this should cause no reload of the main css/js files if they are already cached by the browser. If webpackBuildIdFile is not found return a fallback query that will make the browser reload css/js. - Some eslint in webpack dir.
|
You already have the version there in /client/app so I dont think you need to call from the top consumer 3a1cb56 I'm not good with the html and js side so difficult for me to give valuable comments there. |
There was a problem hiding this comment.
I think we should use what's written here for the caching:
https://webpack.js.org/guides/caching/
This can be a separate PR though, as it's independent from updating the version ID.
Issue: #3091