Fix Pylint warnings #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofri
force-pushed
the
fix_pylint_warnings
branch
from
4d6a03c
to
9fba716
Compare
thib-s
reviewed
Nov 9, 2023
There was a problem hiding this comment.
We need to check if the argument training can be removed. ( especially when calling model(x, training=True) )
(this behavior might be dependent on the tf version)
There was a problem hiding this comment.
Maybe we should keep **kwargs in the call when training is not used?
thib-s
reviewed
Nov 9, 2023
y-prudent
reviewed
Nov 9, 2023
There was a problem hiding this comment.
Maybe we should keep **kwargs in the call when training is not used?
In unconstrained.py, the method is passed as private (starting with an underscore), as it is not expected to be used by any user. Docstring is then no required on private method.
Condition with "layer.threshold" and "layer.negative_slope" returns a np.bool and not a standard bool. Then 'np.bool_(True) is True' returns False So bool type is enforced. WIP model.py bool() because of np.bool_ is True...
thib-s
force-pushed
the
fix_pylint_warnings
branch
from
9fba716
to
fa537c8
Compare
thib-s
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylint returns relevant warnings which are not raised by flake8, the linter used in our CI process. This PR aims at fixing some of these errors to improve deel-lip base code. Each commit of this PR deals with one message type, given in the commit message.
Descriptions for all Pylint messages can be found here.