Skip to content

Fix: Intel classic (icpc) build error "EKinetic is not a template" #7929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mohanchen merged 2 commits into from
Sep 8, 2026
Merged

Fix: Intel classic (icpc) build error "EKinetic is not a template" #7929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16643f7
refactor: drop shared __EKINETICTEMPLATE include-guard macro
lyb9812 Sep 7, 2026
39fa910
fix(lcao): name out-of-line EKinetic dtor without template argument list
lyb9812 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/source_lcao/module_operator_lcao/ekinetic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ hamilt::EKinetic<hamilt::OperatorLCAO<TK, TR>>::EKinetic(

// destructor
template <typename TK, typename TR>
hamilt::EKinetic<hamilt::OperatorLCAO<TK, TR>>::~EKinetic<hamilt::OperatorLCAO<TK, TR>>()
hamilt::EKinetic<hamilt::OperatorLCAO<TK, TR>>::~EKinetic()
{
if (this->allocated)
{
Expand Down
5 changes: 0 additions & 5 deletions source/source_lcao/module_operator_lcao/ekinetic.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@
namespace hamilt
{

#ifndef __EKINETICTEMPLATE
#define __EKINETICTEMPLATE

/// The EKinetic class template inherits from class T
/// it is used to calculate the electronic kinetic
/// Template parameters:
Expand All @@ -25,8 +22,6 @@ class EKinetic : public T
{
};

#endif

/// EKinetic class template specialization for OperatorLCAO<TK> base class
/// It is used to calculate the electronic kinetic matrix in real space and fold it to k-space
/// HR = <psi_{mu, 0}|-\Nabla^2|psi_{nu, R}>
Expand Down
8 changes: 0 additions & 8 deletions source/source_pw/module_pwdft/op_pw_ekin.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,15 +8,7 @@

namespace hamilt {

// Not needed anymore
#ifndef __EKINETICTEMPLATE
#define __EKINETICTEMPLATE

template<class T> class Ekinetic : public T {};
// template<typename R, typename Device = base_device::DEVICE_CPU>
// class Ekinetic : public OperatorPW<T, Device> {};

#endif

// template<typename R, typename Device = base_device::DEVICE_CPU>
// class Ekinetic : public OperatorPW<T, Device>
Expand Down
Loading