Skip to content

Fix DSP linking order to eliminate Openblas warning #7946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Cstandardlib wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Fix DSP linking order to eliminate Openblas warning #7946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4eb3334
Fix dsp linking order to put ScaLapack after Openblas
Cstandardlib Sep 9, 2026
6b53ec6
Revert "Fix dsp linking order to put ScaLapack after Openblas"
Cstandardlib Sep 11, 2026
f5f016a
Fix dsp linking order to use proper Openblas
Cstandardlib Sep 11, 2026
0af2991
Merge branch 'develop' into dsp-link
Cstandardlib Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions source/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,16 @@ if(NOT MSVC)
list(APPEND _abacus_linalg_libs m)
endif()

# The mtblas archives bundle their own OpenBLAS objects. They must come after
# the standalone BLAS/LAPACK/ScaLAPACK above so that the linker resolves the
# BLAS symbols from the standalone BLAS instead of the bundled copy.
if(USE_DSP)
list(APPEND _abacus_linalg_libs
${MTBLAS_FFT_DIR}/libmtblas/lib/libmtblas.a
${MTBLAS_FFT_DIR}/libmtblas/lib/libmtblasdev.a
${MTBLAS_FFT_DIR}/libmtblas/lib/libmtfft.a)
endif()

target_link_libraries(abacus_linalg_libs INTERFACE ${_abacus_linalg_libs})
target_include_directories(abacus_linalg_libs INTERFACE ${_abacus_linalg_include_dirs})

Expand Down
4 changes: 0 additions & 4 deletions source/source_base/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,6 @@ add_library(
)

target_link_libraries(base PUBLIC container)
if (USE_DSP)
target_link_libraries(base PUBLIC ${MTBLAS_FFT_DIR}/libmtblas/lib/libmtblas.a)
target_link_libraries(base PUBLIC ${MTBLAS_FFT_DIR}/libmtblas/lib/libmtblasdev.a)
endif()
add_subdirectory(module_container)

if(ENABLE_COVERAGE)
Expand Down
6 changes: 2 additions & 4 deletions source/source_basis/module_pw/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,8 @@ add_library(
)

if (USE_DSP)
target_link_libraries(planewave PRIVATE
${MTBLAS_FFT_DIR}/libmtblas/lib/libmtfft.a)
target_compile_definitions( planewave PUBLIC
FFT_DAT_DIR="${MTBLAS_FFT_DIR}/datfile/mt_fft_blas.dat")
target_compile_definitions( planewave PUBLIC
FFT_DAT_DIR="${MTBLAS_FFT_DIR}/datfile/mt_fft_blas.dat")
endif()
if(ENABLE_COVERAGE)
add_coverage(planewave)
Expand Down
Loading