refactor MDCell and domain decomposition interfaces - #7954
Open
19hello wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reminder
AGENTS.mdanddocs/developers_guide/agent_governance.md.Linked Issue
This is a core MDCell and domain-decomposition interface refactor. No separate issue is required because the changes are being developed and
reviewed as a focused refactoring PR.
Unit Tests and/or Case Tests for my changes
Commands run:
cmake --build build_parallel_md1_current --target MODULE_MD_run MODULE_MD_func MODULE_CELL_NEIGHBOR_mdcell_migrate_mpi -j4python3 tools/03_code_analysis/agent_governance_check.py --stagedgit diff --checkcell.nat(),mdcell.nat(), anducell.nat()calls.Result summary:
MODULE_MD_runpassed.MODULE_MD_funcpassed.MODULE_CELL_NEIGHBOR_mdcell_migrate_mpipassed.git diff --checkpassed.BaseCell::nat()interface were found.Checks not run, with reason:
restrictions, and the available external runtime environment has unresolved BLAS symbol issues.
What's changed?
MDCell,BaseCell, andDomainDecompositioninterfaces.BaseCell::kind()to a virtual interface implemented directly byMDCellandUnitCell.MDCellandDomainDecompositiondeclarations and definitions by lifecycle, initialization, neighbor-list, geometry, communication,and helper responsibilities.
neighbor_reference_frac_.Governance Notes
INPUT/docs changes:
Core module impact:
BaseCellandMDCellinterface changes affect Cell consumers.UnitCell::natorMDCell::nat_as appropriate.Exceptions requested:
and PR documentation metadata.