source_estate: remove three #define private public in the charge/DM tests, redoing #7988 and #7990 on top of #7972

[Critsium-xy]

Why this reopens closed work

@mohanchen closed #7988 ("The files will be refactored.") and #7990 ("I will refactor these files, so I will close this PR first. Reopen if needed.") because the charge density module was being restructured. That restructuring has landed as #7972, so this is the redo against the new tree.

#7972 already did most of what those PRs proposed, which makes this version much smaller. Charge::allocate(), renormalize_rho() and sum_rho() now take their inputs explicitly, the mixing parameters are aggregated into MixingConfig, and chg_mix.cpp / chg_drho.cpp / charge.cpp no longer read the global parameter singleton at all. In particular the Charge::allocate() signature change and the nelec member that #7990 proposed are obsolete and not included here - #7972 covers that ground.

What was left was purely the test-side access.

Production changes: additive only

No existing signature moves, and no line is deleted from any production header - the three headers are add-only, which should keep this clear of any further work in the module.

addition	rationale
Charge::get_allocate_rho()	report whether allocate() has run
Charge_Mixing::get_rho_mdata()	mirrors the existing get_dmr_mdata()
Charge_Mixing::get_tau_mdata()	same
Charge_Mixing::set_mixing_config()	pair for the existing get_mixing_config(), for callers that must update the snapshot without rebuilding the mixing history
XC_Functional::set_func_type()	pair for get_func_type()
XC_Functional::set_ked_flag()	pair for get_ked_flag()

Test changes

file	change	macro
test_dm_r_init.cpp	2 sites move to the already public get_DMR_save(); no production change needed	removed
test_charge.cpp	global parameter scratchpad becomes fixture state (32 refs -> 0); PW_Basis setup uses the public initgrids/initparameters/setuptransform() instead of the protected distribute_r()/distribute_g()	removed
test_chg_mix.cpp	scratchpad becomes a fixture-owned MixingConfig (163 refs -> 0); the three blocks that hand-wired Charge::_space_* now take buffers from the fixture, which owns them as vectors and points the public rho/rhog/kin_r views at them with the same stride	removed

#define private public in the tree: 17 files -> 14. test_chg_extra.cpp is the remaining one in this module and is deliberately left for a follow-up; no file whose macro survives is touched.

No expected value or tolerance was changed.

Verification

Full build with -DBUILD_TESTING=ON -DENABLE_LCAO=ON -DENABLE_MPI=ON -DENABLE_OPENMP=ON: exit 0, zero errors, and all three changed test files confirmed compiled.

MODULE_CHARGE + MODULE_ESTATE + MODULE_HAMILT: 41/41 pass, matching the develop baseline built in the same tree.

Running the tests rather than trusting the build mattered here - it caught a variable-shadowing bug where the two Kerker cases already had a local MixingConfig cfg, so setting nspin on it instead of on the fixture under-allocated the arrays and read out of bounds. The locals are now kcfg.

Governance: zero blockers, net_delta = -196 (added 0, removed 196), and the access-hack ratchet sees 3 removed / 0 added.

No INPUT parameter behaviour changed, so docs/parameters.yaml and input-main.md need no regeneration; the additions are internal accessors with no user-facing surface.

🤖 Generated with Claude Code