refactor: avoid downloading tokenizer if truncate
is False
#1152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
If
truncate
isFalse
, do not initialize thePromptHandler
(which internally downloads the tokenizer).In the Generator, the
PromptHandler
is only used to truncate the text if needed.How did you test it?
CI + a new unit test.
Notes for the reviewer
This change only applies to
AmazonBedrockGenerator
.I would have liked to do the same for the corresponding Chat Generator.
Unfortunately, in the Chat Generator, the
PromptHandler
(and its internal tokenizer) have 2 different purposes:tokenizer.apply_chat_template
)Therefore, we cannot easily get rid of the tokenizer.
(I hope we can prioritize #977 soon: this would greatly simplify the Chat Generator.)
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.