fix: adapt our implementation to breaking changes in Chroma 0.5.17 #1165

anakin87 · 2024-11-04T09:49:13Z

failing tests: https://github.com/deepset-ai/haystack-core-integrations/actions/runs/11655758403
in 0.5.17, Chroma introduced some breaking changes:
- writing documents that do not contain a valid string (None) causes an error
- they changed filter default: from {} to None

CI

I have read the contributors guidelines and the code of conduct
I have updated the related issue with new insights and changes
I added unit tests and updated the docstrings
I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test:.

integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py

fix chroma breaking changes

82e1343

github-actions bot added integration:chroma type:documentation Improvements or additions to documentation labels Nov 4, 2024

anakin87 marked this pull request as ready for review November 4, 2024 09:51

anakin87 requested a review from a team as a code owner November 4, 2024 09:51

anakin87 requested review from Amnah199 and davidsbatista and removed request for a team November 4, 2024 09:51

Amnah199 reviewed Nov 4, 2024

View reviewed changes

integrations/chroma/src/haystack_integrations/document_stores/chroma/document_store.py Outdated Show resolved Hide resolved

improve warning

e9d1fb1

anakin87 requested a review from Amnah199 November 4, 2024 10:56

Provide feedback