Repository navigation
fix(cli): ensure deploy command exits with error if rollout times out - #92
Merged
volkanarisli merged 1 commit intoOct 23, 2026
Conversation
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
volkanarisli
deleted the
feature/eco-1227-a-ci-jobs-result-tells-the-truth-about-the-deploy
branch
October 23, 2026 07:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deployexited 0 when the rollout didn't finish within the 10-minute wait limit, so a CI job passed without the new revision serving.Now a timed-out rollout exits 1. Ctrl-C and
--skip-activationstill exit 0, because the user chose to detach. The timeout message now says the revision is not confirmed to be serving.Docs:
AGENTS.mdand the deploy guide now list the exit codes, and the guide has a new "What the job result means" section for CI.