Skip to content

fix: write extraction bundle to a temp dir so Windows can open it #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrchtr merged 1 commit into from
Oct 23, 2026
Merged

fix: write extraction bundle to a temp dir so Windows can open it #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions haystack_enterprise_sdk/_service/pipeline_transform.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,11 @@ def extract_via_subprocess(
python = python_executable or detect_project_python(target)
extractor = str(Path(__file__).with_name("pipeline_extract.py"))

with tempfile.NamedTemporaryFile("r", suffix=".json", delete=True) as out_file:
cmd = [python, extractor, str(target), "--out", out_file.name]
# A temp dir rather than NamedTemporaryFile: on Windows an open NamedTemporaryFile is locked, so the
# subprocess cannot write to it (PermissionError).
with tempfile.TemporaryDirectory() as tmp_dir:
out_path = Path(tmp_dir) / "bundle.json"
cmd = [python, extractor, str(target), "--out", str(out_path)]
if entrypoint:
cmd += ["--entrypoint", entrypoint]
logger.debug("Extracting pipeline via subprocess.", python=python, target=str(target))
Expand All @@ -538,8 +541,7 @@ def extract_via_subprocess(
message = completed.stderr.strip() or completed.stdout.strip() or "unknown error"
raise PipelineTransformError(f"Failed to load the pipeline using interpreter '{python}':\n{message}")
_forward_extractor_warnings(completed.stderr)
out_file.seek(0)
return ExtractionBundle.from_dict(json.load(out_file))
return ExtractionBundle.from_dict(json.loads(out_path.read_text(encoding="utf-8")))


def _forward_extractor_warnings(stderr: str) -> None:
Expand Down
Loading