Repository navigation
fix(cli): verify TLS against the OS trust store - #96
Merged
Merged
Conversation
On Windows behind TLS-inspecting corporate proxies, login and other commands failed with CERTIFICATE_VERIFY_FAILED: httpx/aiohttp use certifi, which lacks the proxy's root CA installed in the OS store. Inject truststore in the CLI entrypoint only. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
volkanarisli
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Windows behind a TLS-inspecting corporate proxy,
haystack-enterprise login(and other commands) fail withCERTIFICATE_VERIFY_FAILED. httpx and aiohttp check certificates against certifi's bundled list, which doesn't include the proxy's root certificate. That certificate is installed in the Windows store, which is why the browser login page works.Fix
truststore.inject_into_ssl()in the CLI entry point (run_packaged), so every command checks certificates against the OS store.sslalone;AGENTS.mdexplains how to opt in.truststore>=0.10.0as a dependency (uv.lockupdated).Testing
make tests-unit(770 passed),make types,make all-fix,uv lock --checkall pass.🤖 Generated with Claude Code
https://claude.ai/code/session_019FaSZo4b27zdYaxRGv43ZK