fix: rollback booking when all calendar integrations fail - #4
Open
deepshekhardas wants to merge 2 commits into
Open
deepshekhardas wants to merge 2 commits into
deepshekhardas wants to merge 2 commits into
Conversation
added 2 commits
May 11, 2026 14:38
- Add minimumCancellationNotice field to EventType model and types - Create DisableCancellingController component with UI for setting notice period - Add server-side validation in handleCancelBooking - Add client-side validation in booking actions and booking details page - Add isWithinMinimumCancellationNotice utility function Closes calcom#15647
When all calendar integrations (Google Calendar, Outlook, etc.) fail to create events, the booking is now rolled back and cancelled instead of being left as ACCEPTED with no calendar event. This prevents data inconsistency where bookings appear confirmed but have no corresponding calendar event. - Added rollback logic for new bookings when all calendar creation fails - Added rollback logic for rescheduling when all calendar updates fail - Updated error messages to be more user-friendly Closes calcom#28397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When all calendar integrations (Google Calendar, Outlook, etc.) fail to create events, the booking is now rolled back and cancelled instead of being left as ACCEPTED with no calendar event. This prevents data inconsistency where bookings appear confirmed but have no corresponding calendar event.
Changes
The Bug
Previously, when calendar sync failed (due to API timeout, invalid token, rate limit), the booking would be saved as ACCEPTED in the database but no calendar event would be created. This led to:
The Fix
When ALL calendar integrations fail:
Note: Partial failures (some calendars succeed, some fail) are still logged but not rolled back, as at least some calendars have the event.
Closes calcom#28397
Summary by cubic
Rolls back and cancels bookings when all calendar integrations fail, preventing confirmed bookings without calendar events (Linear calcom#28397). Also adds a minimum cancellation notice setting with UI and validation.
New Features
Bug Fixes
Written for commit 369501f. Summary will update on new commits.