Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set helm buildflags the way Zarf does #1052

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

catsby
Copy link
Collaborator

@catsby catsby commented Dec 20, 2024

Description

Without setting these buildflags, some uds zarf commands could produce different results than directly using zarf of the same version. See details for example.

❯ uds version               
v0.20.0

❯ uds zarf version                    
v0.45.0

❯ zarf version                    
v0.45.0

❯ uds zarf dev find-images -f upstream
[... omitted things ...]
 NOTE  Using build directory .
     [... omitted things ...]
     ERROR:  unable to find images: could not render the Helm template for [some chart]: error
             generating helm chart template: chart requires kubeVersion: >=1.24.0-0 which is incompatible with
             Kubernetes v1.20.0

❯ zarf dev find-images -f upstream    
[... omitted things ...]
 NOTE  Using build directory .
  [... omitted things ...]
components:

  - name: [some chart]
    images:
      - alpine
      - nats:2.10.19-alpine
      - [other images]

In this PR we add the necessary variables and buildflags to get the correct results in a similar manner to how Zarf does.

❯ uds zarf dev find-images -f upstream    
[... omitted things ...]
 NOTE  Using build directory .
  [... omitted things ...]
components:

  - name: [some chart]
    images:
      - alpine
      - nats:2.10.19-alpine
      - [other images]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

@catsby catsby requested a review from a team as a code owner December 20, 2024 22:23
@catsby catsby requested review from Racer159 and daveworth December 20, 2024 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant