feat: add 'dev tofu-create' command to build bundles from a uds-bundle.tf config #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catsby
approved these changes
Jan 24, 2025
| return err | ||
| } | ||
|
|
||
| // Fake metadata for now |
| Description: *tfConfig.Metadata.Description, | ||
| } | ||
|
|
||
| // Parse each Package resoruce and convert it types.Package type |
There was a problem hiding this comment.
Suggested change
| // Parse each Package resoruce and convert it types.Package type | |
| // Parse each Package resoruce and convert it to types.Package type |
| @@ -88,6 +120,7 @@ func (b *Bundle) Create() error { | |||
| } | |||
| } | |||
|
|
|||
| // TODO: @JPERRY this dev eploy block has not been validated to work with tofu based bundles yet | |||
There was a problem hiding this comment.
Suggested change
| // TODO: @JPERRY this dev eploy block has not been validated to work with tofu based bundles yet | |
| // TODO: @JPERRY this dev deploy block has not been validated to work with tofu based bundles yet |
Comment on lines
+113
to
125
| var bundleManifestDesc ocispec.Descriptor | ||
| if lo.isTofu { | ||
| bundleManifestDesc, err = pushBundleTFToStore(store, filepath.Join(lo.sourceDir, config.BundleTF)) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } else { | ||
| // push uds-bundle.yaml to OCI store | ||
| bundleManifestDesc, err = pushBundleYAMLToStore(store, bundle) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: style suggestion
Suggested change
| var bundleManifestDesc ocispec.Descriptor | |
| if lo.isTofu { | |
| bundleManifestDesc, err = pushBundleTFToStore(store, filepath.Join(lo.sourceDir, config.BundleTF)) | |
| if err != nil { | |
| return err | |
| } | |
| } else { | |
| // push uds-bundle.yaml to OCI store | |
| bundleManifestDesc, err = pushBundleYAMLToStore(store, bundle) | |
| if err != nil { | |
| return err | |
| } | |
| } | |
| var bundleManifestDesc ocispec.Descriptor | |
| if lo.isTofu { | |
| // push uds-bundle.tf to OCI store | |
| bundleManifestDesc, err = pushBundleTFToStore(store, filepath.Join(lo.sourceDir, config.BundleTF)) | |
| } else { | |
| // push uds-bundle.yaml to OCI store | |
| bundleManifestDesc, err = pushBundleYAMLToStore(store, bundle) | |
| } | |
| if err != nil { | |
| return err | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parses
uds-bundle.tffiles and generates auds-bundle-fake-metadata-0.0.0.tar.zsttarball bundle.There is (a lot) more work that will need to be implemented to ensure full feature parity with the standard
uds createfrom auds-bundle.yamlfile, but I believe this PR offers a good starting point.The changes in this PR add additional config booleans to check against so we do not change the behavior of a standard
uds createcommand.Type of change
Checklist before merging
😰😬🙈